Skip to content

public/uploads/rules/forms do-you-indicate-which-fields-are-required-and-validate-them/rule (PR from TinaCMS)#12507

Open
tiagov8 wants to merge 13 commits intomainfrom
tina/public/uploads/rules/forms-do-you-indicate-which-fields-are-required-and-validate-them/rule
Open

public/uploads/rules/forms do-you-indicate-which-fields-are-required-and-validate-them/rule (PR from TinaCMS)#12507
tiagov8 wants to merge 13 commits intomainfrom
tina/public/uploads/rules/forms-do-you-indicate-which-fields-are-required-and-validate-them/rule

Conversation

@tiagov8
Copy link
Copy Markdown
Member

@tiagov8 tiagov8 commented Apr 17, 2026 •
edited
Loading

cc @joshbermanssw @adamcogan @JeanThirion @andrewwaltosssw

Email thread: Re: EasyLeave validation

I also moved forms rules from "layout" to "forms" category

@tiagov8
TinaCMS content update
94d4af9 
Co-authored-by: Tiago Araujo <TiagoAraujo@ssw.com.au>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2026 •
edited
Loading

🔍 Preview PR Changes

View updated pages in edit mode:

Branch: tina/public/uploads/rules/forms-do-you-indicate-which-fields-are-required-and-validate-them/rule

@tiagov8 tiagov8 marked this pull request as ready for review April 17, 2026 22:20
@tiagov8 tiagov8 requested a review from joshbermanssw April 17, 2026 22:20
@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Apr 17, 2026
@tiagov8 tiagov8 requested a review from designbyalex April 17, 2026 22:20
@tiagov8 tiagov8 enabled auto-merge (squash) April 17, 2026 22:23
@tiagov8 tiagov8 mentioned this pull request Apr 17, 2026
Open
@github-actions github-actions bot added Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old Age: 🍗 - Ancient About 64 hours old and removed Age: 🥚 - New About 2 hours old Age: 🐣 - Young About 4 hours old Age: 🐥 - Adolescent About 8 hours old Age: 🐤 - Mature About 16 hours old Age: 🐓 - Old About 32 hours old labels Apr 18, 2026
@github-actions github-actions bot added the 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/ label Apr 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2026

Howzit @tiagov8,

This PR has been here a while.

Did you know you should avoid merge debt?

  1. Please action (e.g. get a review) and merge or close

Thanks!

joshbermanssw
joshbermanssw requested changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@joshbermanssw joshbermanssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal nit-pick. I would call both these forms bad examples as the sign in button is enabled when the form is invalid

Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshbermanssw joshbermanssw joshbermanssw requested changes

@andrewwaltosssw andrewwaltosssw andrewwaltosssw approved these changes

@designbyalex designbyalex Awaiting requested review from designbyalex

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Age: 🍗 - Ancient About 64 hours old 🔥 Merge Debt This PR contains merge debt, see https://www.ssw.com.au/rules/merge-debt/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tiagov8 @andrewwaltosssw @joshbermanssw