fix: correct release workflow sequencing to merge changelog PR before tagging#40
fix: correct release workflow sequencing to merge changelog PR before tagging#40
Conversation
ricogu-claw
left a comment
There was a problem hiding this comment.
This is a solid fix for the core sequencing issue: the workflow now waits for the changelog PR to merge before proceeding to tagging, which addresses the main failure mode we saw.
A couple of points I’d still want called out before merge:
-
This fixes sequencing, but not full changelog/release-note consistency
The workflow still creates the GitHub release body fromsteps.changelog.outputs.changeloginstead of the final mergedCHANGELOG.mdcontent:body: ${{ steps.changelog.outputs.changelog }}
So the changelog in the repo and the GitHub release notes can still drift if the generated content is modified before merge. I opened #50 to track that follow-up explicitly.
-
Please keep this PR scoped to the workflow fix only
If there are any unrelated changes on the branch (for example changelog/package/dist files picked up during development), I’d drop them before merge so this stays focused on the release sequencing change. -
Auto-merge is now a workflow dependency
The new flow depends on repo settings / branch protection allowinggh pr merge --auto --squashto complete successfully. That is fine if intentional, but worth being explicit about.
Overall: I think this is moving in the right direction and is mergeable once the scope is clean and the above limitation is understood.
|
Follow-up for the remaining gap after this sequencing fix: #50 I updated the issue description to make the context concrete and to reference the right PRs:
The remaining tracking item is that the GitHub release body is still derived from the pre-merge generated changelog output rather than the final merged |
Summary
This PR fixes the release workflow which had a critical sequencing issue where the changelog PR was created but never merged before the release was tagged.
Changes
fromTagdetection: New step to get the previous release tag for proper changelog delta generationgh pr merge --auto --squashNew Workflow Flow
Requirements