[WIP] v2.x - Nokogiri Refactor Part X - Conversion of SignedDocument (shimmed version)#757
Closed
johnnyshields wants to merge 3 commits intoSAML-Toolkits:v2.xfrom
Closed
[WIP] v2.x - Nokogiri Refactor Part X - Conversion of SignedDocument (shimmed version)#757johnnyshields wants to merge 3 commits intoSAML-Toolkits:v2.xfrom
johnnyshields wants to merge 3 commits intoSAML-Toolkits:v2.xfrom
Conversation
…remove its REXML dependency
commit 3ad82eb Author: johnnyshields <27655+johnnyshields@users.noreply.github.com> Date: Fri Mar 14 22:07:46 2025 +0900 WIP on conversion of SignedDocument
…or-final' into v2.x-nokogiri-parrtial-upgrade-phase-3
johnnyshields
changed the title
johnnyshields
changed the title
Collaborator
Author
|
Abandoned this branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt of migrating SignedDocument by first shimming/wrapping it before converting REXML.