V2.x - Nokogiri Upgrade Part 4 - Convert RubySaml::XML::Document to DocumentSigner#745
Merged
pitbulk merged 7 commits intoSAML-Toolkits:v2.xfrom Mar 19, 2025
Conversation
johnnyshields
changed the title
Collaborator
Author
|
@pitbulk thanks for merging the two PRs earlier. In those PRs, we are using more Nokogiri internally, however, we have logic to convert to Rexml when passing data between classes. This PR switches to using "pure Nokogiri" for document building and document signing. However, I found a JRuby Nokogiri bug which breaks our test cases (particularly regexes on the documents). You can see the failures in the CI below. I patched the bug here, but we'll have to wait till it's merged and released. So I will probably hold off on further Nokogiri conversion for now. |
johnnyshields
changed the title
johnnyshields
changed the title
johnnyshields
changed the title
Collaborator
Author
This was referenced Mar 13, 2025
…remove its REXML dependency
johnnyshields
force-pushed
the
v2.x-nokogiri-parrtial-upgrade-phase-3
branch
from
d0c221b to
4c6475c
Compare
johnnyshields
force-pushed
the
v2.x-nokogiri-parrtial-upgrade-phase-3
branch
from
6d5ece1 to
372d30a
Compare
Collaborator
Author
|
@pitbulk please merge 🎉 |
johnnyshields
changed the title
johnnyshields
changed the title
pitbulk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches to using "pure Nokogiri" for document building and document signing.
Also includes changes from #748
TODO:
Blocked until Fix MRI Ruby vs. JRuby XML child namespace output differences sparklemotion/nokogiri#3456 is releasedSwitch to Nokogiri XML builder everywhereUse sign_document! (bang) where appropriate