V2.x - Nokogiri Upgrade Part 1 - Always double quote XML#744
Merged
pitbulk merged 5 commits intoSAML-Toolkits:v2.xfrom Mar 9, 2025
Merged
V2.x - Nokogiri Upgrade Part 1 - Always double quote XML#744pitbulk merged 5 commits intoSAML-Toolkits:v2.xfrom
pitbulk merged 5 commits intoSAML-Toolkits:v2.xfrom
Conversation
johnnyshields
changed the title
pitbulk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pitbulk this PR deprecates
double_quote_xml_attribute_valuesand always makes it behave as true. The reason is that Nokogiri can't generate single quoted XML, and there's no reason to support it.The PR also includes migration from
RubySaml::XML::Document::*constants toRubySaml::XML::Crypto::*, mainly in tests.Coveralls failures can be ignored; its just for deprecated code that will be removed in future phases.
Please merge.