Skip to content

feat: enable screen sharing on external calls#40211

Draft
pierre-lehnen-rc wants to merge 1 commit intochore/p2p-stream-id-syncingfrom
feat/enable-screen-sharing-on-sip-calls
Draft

feat: enable screen sharing on external calls#40211
pierre-lehnen-rc wants to merge 1 commit intochore/p2p-stream-id-syncingfrom
feat/enable-screen-sharing-on-sip-calls

Conversation

@pierre-lehnen-rc
Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Enables the screen-sharing functionality on external calls.

Issue(s)

Steps to test or reproduce

Further comments

We'll need to lock this behind a setting, as this change may break external calls with services that do not support video and/or data channels.

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 17, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 17, 2026

⚠️ No Changeset found

Latest commit: 54c85be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 17, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: efdb85e0-be7c-49f5-9664-63b0a341f80b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.21%. Comparing base (d52104e) to head (54c85be).

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##           chore/p2p-stream-id-syncing   #40211      +/-   ##
===============================================================
+ Coverage                        69.72%   70.21%   +0.48%     
===============================================================
  Files                             3290     3280      -10     
  Lines                           119072   116876    -2196     
  Branches                         21420    20720     -700     
===============================================================
- Hits                             83026    82061     -965     
+ Misses                           32739    31537    -1202     
+ Partials                          3307     3278      -29     
Flag Coverage Δ
e2e 59.69% <ø> (+<0.01%) ⬆️
e2e-api 46.44% <ø> (+0.20%) ⬆️
unit 71.08% <ø> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant