feat: enable screen sharing on external calls#40211
feat: enable screen sharing on external calls#40211pierre-lehnen-rc wants to merge 1 commit intochore/p2p-stream-id-syncingfrom
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/p2p-stream-id-syncing #40211 +/- ##
===============================================================
+ Coverage 69.72% 70.21% +0.48%
===============================================================
Files 3290 3280 -10
Lines 119072 116876 -2196
Branches 21420 20720 -700
===============================================================
- Hits 83026 82061 -965
+ Misses 32739 31537 -1202
+ Partials 3307 3278 -29
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Enables the screen-sharing functionality on external calls.
Issue(s)
Steps to test or reproduce
Further comments
We'll need to lock this behind a setting, as this change may break external calls with services that do not support video and/or data channels.