Fix paste-over-selection for decimal numericInput masks (#2603)#2880
Draft
Fix paste-over-selection for decimal numericInput masks (#2603)#2880
Conversation
Agent-Logs-Url: https://github.com/RobinHerbots/Inputmask/sessions/20d8a3cb-550a-454e-9080-8bced95c6eb6 Co-authored-by: RobinHerbots <318447+RobinHerbots@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix paste value functionality in input field
Fix paste-over-selection for decimal numericInput masks (#2603)
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a decimal mask field (with
numericInput/RTL behavior) had all text selected and the user pasted, the pasted value was not replacing the existing content — it was being combined with or appended to it.Root Cause
In
handlePaste, the caret position was being read with RTL coordinate translation applied. For a fully-selected field showing"12345.22"(selectionStart=0, selectionEnd=8), the translated coords became{begin:8, end:0}, causingvalueBeforeCaretandvalueAfterCaretto include the existing content. The pasted value was then concatenated with the old value before being processed bycheckVal.Fix
Pass
notranslate=trueto thecaret()call insidehandlePasteso that raw DOMselectionStart/selectionEndvalues are used directly — consistent with visual coordinates already expected for constructing the replacement string:With
{begin:0, end:N}for select-all, bothvalueBeforeCaretandvalueAfterCaretare empty, and the pasted value is passed cleanly tocheckVal(which resets the mask before processing).Test
Added
"decimal select all paste - #2603"inqunit/tests_paste.jsusing the exact options from the report (alias: "decimal",allowMinus,autoGroup,clearMaskOnLostFocus: false,digits: 2,digitsOptional: false,groupSeparator: "",groupSize: 3,max/minbounds) — type a value, select all, paste a new value, assert replacement.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
accounts.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4930 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53070824 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5177325583111241781,15055828271590705466,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16255843969270510661,13669344331208660762,4 --trace-process-track-uuid=3190708989122997041 git(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53070824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-web-security http://localhost:9876/?id=53070824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5097 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-48197985 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11027336736553365076,14309519239398262737,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10370370540655031995,8135584212624655257,4 --trace-process-track-uuid=3190708989122997041 git(dns block)android.clients.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4930 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53070824 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5177325583111241781,15055828271590705466,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16255843969270510661,13669344331208660762,4 --trace-process-track-uuid=3190708989122997041 git(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53070824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-web-security http://localhost:9876/?id=53070824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5097 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-48197985 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11027336736553365076,14309519239398262737,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10370370540655031995,8135584212624655257,4 --trace-process-track-uuid=3190708989122997041 git(dns block)api.browserstack.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/Inputmask/Inputmask/node_modules/.bin/karma start karma.conf.js --single-run ACCEPT(dns block)clients2.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4930 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53070824 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5177325583111241781,15055828271590705466,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16255843969270510661,13669344331208660762,4 --trace-process-track-uuid=3190708989122997041 git(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53070824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-web-security http://localhost:9876/?id=53070824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5097 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-48197985 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11027336736553365076,14309519239398262737,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10370370540655031995,8135584212624655257,4 --trace-process-track-uuid=3190708989122997041 git(dns block)clientservices.googleapis.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4930 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53070824 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5177325583111241781,15055828271590705466,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16255843969270510661,13669344331208660762,4 --trace-process-track-uuid=3190708989122997041 git(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53070824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-web-security http://localhost:9876/?id=53070824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5097 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-48197985 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11027336736553365076,14309519239398262737,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10370370540655031995,8135584212624655257,4 --trace-process-track-uuid=3190708989122997041 git(dns block)content-autofill.googleapis.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4930 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53070824 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5177325583111241781,15055828271590705466,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16255843969270510661,13669344331208660762,4 --trace-process-track-uuid=3190708989122997041 git(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53070824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-web-security http://localhost:9876/?id=53070824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5097 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-48197985 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11027336736553365076,14309519239398262737,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10370370540655031995,8135584212624655257,4 --trace-process-track-uuid=3190708989122997041 git(dns block)local.browserstack.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/Inputmask/Inputmask/node_modules/browserstack-local/lib/fetchDownloadSourceUrl.js BROWSERSTACK_ACCESS_KEY undefined false null(dns block)redirector.gvt1.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4930 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53070824 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5177325583111241781,15055828271590705466,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16255843969270510661,13669344331208660762,4 --trace-process-track-uuid=3190708989122997041 git(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53070824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-web-security http://localhost:9876/?id=53070824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5097 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-48197985 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11027336736553365076,14309519239398262737,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10370370540655031995,8135584212624655257,4 --trace-process-track-uuid=3190708989122997041 git(dns block)safebrowsingohttpgateway.googleapis.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4930 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53070824 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5177325583111241781,15055828271590705466,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16255843969270510661,13669344331208660762,4 --trace-process-track-uuid=3190708989122997041 git(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53070824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-web-security http://localhost:9876/?id=53070824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5097 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-48197985 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11027336736553365076,14309519239398262737,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10370370540655031995,8135584212624655257,4 --trace-process-track-uuid=3190708989122997041 git(dns block)www.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=4930 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-53070824 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,5177325583111241781,15055828271590705466,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16255843969270510661,13669344331208660762,4 --trace-process-track-uuid=3190708989122997041 git(dns block)/opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-53070824 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-web-security http://localhost:9876/?id=53070824 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5097 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-48197985 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11027336736553365076,14309519239398262737,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,10370370540655031995,8135584212624655257,4 --trace-process-track-uuid=3190708989122997041 git(dns block)If you need me to access, download, or install something from one of these locations, you can either: