-
Notifications
You must be signed in to change notification settings - Fork 24
Limit concurrent workers in batch #873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -306,6 +306,7 @@ | |||||
| 'enabled': False, # Set to True to enable pipe mode (it is off by default, use it for large compute campaigns). | ||||||
| 'min_tasks': 10, # Minimum batch size to trigger pipe mode. | ||||||
| 'max_workers': 100, # Upper bound on array worker slots per PipeRun. | ||||||
| 'max_concurrent': None, # Max array workers running simultaneously (like PBS `%N`). None = unthrottled. | ||||||
|
||||||
| 'max_concurrent': None, # Max array workers running simultaneously (like PBS `%N`). None = unthrottled. | |
| 'max_concurrent': None, # Max array workers running simultaneously (like PBS `%N`). None or non-positive values disable throttling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max_concurrenthas implicit semantics for non-positive values (e.g.,0disables throttling) but this isn’t clearly part of the public API contract ofPipeRun. Consider normalizing/validatingmax_concurrentat construction time (e.g., coerce non-positive toNone, or raise on negatives) and documenting the supported values in the class docstring to avoid silent configuration mistakes.