Skip to content

Add ruff linting#860

Open
alongd wants to merge 1 commit intomainfrom
ruff
Open

Add ruff linting#860
alongd wants to merge 1 commit intomainfrom
ruff

Conversation

@alongd
Copy link
Copy Markdown
Member

@alongd alongd commented Apr 8, 2026

Add ruff as ARC's linter: config in pyproject.toml, workflow in .github/workflows/ruff.yml, status badge in the README.

Ruff currently runs in non-blocking mode (continue-on-error: true)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Ruff as a (currently non-blocking) linter/formatter check for ARC, wiring it into repo config, CI, and documentation so contributors can see lint status on PRs.

Changes:

  • Add Ruff configuration to pyproject.toml (rule selection, ignores, per-file ignores, and format settings).
  • Add a GitHub Actions workflow to run ruff check and ruff format --check on PRs and main (non-blocking).
  • Add a Ruff status badge to the README.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
README.md Adds a Ruff workflow badge to surface lint status.
pyproject.toml Introduces Ruff lint/format configuration and project-specific excludes/ignores.
.github/workflows/ruff.yml Adds a CI workflow that runs Ruff in continue-on-error mode.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml Outdated
Comment thread .github/workflows/ruff.yml Outdated
Comment thread pyproject.toml
Comment thread pyproject.toml Outdated
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.13%. Comparing base (606bbe2) to head (f7bd0ab).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
- Coverage   60.13%   60.13%   -0.01%     
==========================================
  Files         102      102              
  Lines       31043    31043              
  Branches     8082     8082              
==========================================
- Hits        18669    18667       -2     
  Misses      10067    10067              
- Partials     2307     2309       +2     
Flag Coverage Δ
functionaltests 60.13% <ø> (-0.01%) ⬇️
unittests 60.13% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pyproject.toml
"*.egg-info",
".eggs",
"ipython", # notebook tutorials
"arc/molecule", # Cython-compiled sources + tightly coupled modules
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calvinp0, as discusses offline, now we ignore the entire molecule module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants