Skip to content

Added icon for google sleep plugin#134

Open
this-Aditya wants to merge 1 commit intoRADAR-base:devfrom
this-Aditya:sleep-icon
Open

Added icon for google sleep plugin#134
this-Aditya wants to merge 1 commit intoRADAR-base:devfrom
this-Aditya:sleep-icon

Conversation

@this-Aditya
Copy link
Copy Markdown
Member

Updated the icon or google sleep plugin.

@this-Aditya this-Aditya changed the base branch from master to dev July 18, 2023 14:05
@this-Aditya
Copy link
Copy Markdown
Member Author

Screenshot_20230718-193634

Copy link
Copy Markdown
Collaborator

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps this would be a good generalization to add to the provider
fun imageResource(state: T?): Int
where each provider can implement their own image resource. For most devices that would be battery, but for others it can be just an icon.

@this-Aditya
Copy link
Copy Markdown
Member Author

Sure, thanks! I will update the Provider class soon.

@yatharthranjan
Copy link
Copy Markdown
Member

Is this superseded by #135 ?

@this-Aditya
Copy link
Copy Markdown
Member Author

this-Aditya commented May 9, 2024

Hi, it doesn't. The supporting PR for #135 -> RADAR-base/radar-commons-android#437 was closed because it was not working for every plugin.

@yatharthranjan
Copy link
Copy Markdown
Member

Ok in that case, do we need to add more cases here for the other google plugins?

@this-Aditya
Copy link
Copy Markdown
Member Author

this-Aditya commented May 9, 2024

As Joris suggested, it would be nice if generalized via radar-commons-android, and then each plugin can update its icon itself. Is it okay if I try to make it work in another PR again?

@yatharthranjan
Copy link
Copy Markdown
Member

ok, that would be great, thanks.

@this-Aditya
Copy link
Copy Markdown
Member Author

Added new PR here -> #141.

@this-Aditya this-Aditya force-pushed the dev branch 3 times, most recently from 61d7fac to 7e20fe0 Compare March 2, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants