Added icon for google sleep plugin#134
Conversation
blootsvoets
left a comment
There was a problem hiding this comment.
LGTM. Perhaps this would be a good generalization to add to the provider
fun imageResource(state: T?): Int
where each provider can implement their own image resource. For most devices that would be battery, but for others it can be just an icon.
|
Sure, thanks! I will update the Provider class soon. |
|
Is this superseded by #135 ? |
|
Hi, it doesn't. The supporting PR for #135 -> RADAR-base/radar-commons-android#437 was closed because it was not working for every plugin. |
|
Ok in that case, do we need to add more cases here for the other google plugins? |
|
As Joris suggested, it would be nice if generalized via radar-commons-android, and then each plugin can update its icon itself. Is it okay if I try to make it work in another PR again? |
|
ok, that would be great, thanks. |
|
Added new PR here -> #141. |
61d7fac to
7e20fe0
Compare

Updated the icon or google sleep plugin.