Skip to content

feat(announcement-banner): enhance banner functionality with tooltip and multiple banner support#2616

Open
RemiBonnet wants to merge 1 commit intonew-navigationfrom
fix/new-nav/banner-announcement
Open

feat(announcement-banner): enhance banner functionality with tooltip and multiple banner support#2616
RemiBonnet wants to merge 1 commit intonew-navigationfrom
fix/new-nav/banner-announcement

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Apr 21, 2026

Summary

Improve banner announcement responsive and boutons colors

Screenshots / Recordings

Screenshot 2026-04-21 at 18 59 56 Screenshot 2026-04-21 at 19 02 31 Screenshot 2026-04-21 at 19 03 38

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet marked this pull request as ready for review April 21, 2026 17:03
@RemiBonnet RemiBonnet added the V5 label Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (new-navigation@6a865a6). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2616   +/-   ##
=================================================
  Coverage                  ?   89.01%           
=================================================
  Files                     ?        2           
  Lines                     ?       91           
  Branches                  ?       32           
=================================================
  Hits                      ?       81           
  Misses                    ?        4           
  Partials                  ?        6           
Flag Coverage Δ
unittests 89.01% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant