Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## new-navigation #2603 +/- ##
=================================================
Coverage ? 44.92%
=================================================
Files ? 743
Lines ? 17645
Branches ? 5184
=================================================
Hits ? 7927
Misses ? 8328
Partials ? 1390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM! Only small feedback is that the transition when the height change on scroll is different than the header so we have weird jump when scrolling like here: Enregistrement.de.l.ecran.2026-04-16.a.13.52.35.mov |
Thanks, I just fixed this! I tightened the top and height transition so the panel tracks the header more closely while scrolling and feels snappier It still can’t be a perfect sticky behavior on our side because the panel has to recalculate both top and height as the breadcrumb/header changes, so there can be a small transition instead of a fully native sticky feel |
| @@ -0,0 +1,41 @@ | |||
| // XXX: Use this store to avoid re-rendering all pages or routes just to open the documentation | |||
There was a problem hiding this comment.
Could you please explain the re-rendering issue you're talking about here? 🙏 Because for now, it is not clear to me what this workaround is actually solving
There was a problem hiding this comment.
Yep, the issue was mostly about where the open state lived. When it was a useState higher up in the app, opening/closing the documentation panel was causing the whole page tree to re-render, not just the assistant. That created small visual glitches in a few places, especially image-based icons that would flicker/remount
The store workaround is just to scope that state so only the assistant-related components subscribe to it, which avoids those unnecessary re-renders
There was a problem hiding this comment.
I see. That still sounds a bit hacky to me. Couldn't we use a Context instead?
There was a problem hiding this comment.
It was actually a Context + useState at first, and that’s what caused the issue. Since it lived too high in the tree, opening/closing the panel was still re-rendering a much larger part of the app than needed
I’ll try moving it lower on Monday instead of keeping it around the router level, that might be enough to solve it cleanly
There was a problem hiding this comment.
I’ve moved the open state inside the router so it no longer re-renders the whole page, it should behave better now!
Should be better now, I tried moving it directly to CSS to improve the sticky behavior, but there are still a few edge cases. I can take another look on Monday if I come up with a better idea to fix this small jump
Thanks, fixed ! |
3aa60ba to
7c30708
Compare
7c30708 to
f240fee
Compare
…for improved layout and transitions
…agement for improved state handling
…set prop and integrate useStickyBottomOffset hook for improved layout management
…component structure for improved clarity
7932b33 to
32cc002
Compare
…prove animation handling
…ility and consistency



Summary
Add assistant everywhere
Screenshots / Recordings
https://www.loom.com/share/2efe2e4bf9af43c88823d06ec43ea1e7
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release