Skip to content

feat: clean backend endpoint input #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wjiayis wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: clean backend endpoint input #159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dee42b8
feat: clean backend endpoint input
wjiayis Apr 18, 2026
c18ecaf
fix: debug mid-url backslash
wjiayis Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions webapp/_webapp/src/libs/apiclient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class ApiClient {
}

updateBaseURL(baseURL: string, apiVersion: ApiVersion): void {
this.axiosInstance.defaults.baseURL = `${baseURL}/_pd/api/${apiVersion}`;
this.axiosInstance.defaults.baseURL = `${sanitizeEndpoint(baseURL)}/_pd/api/${apiVersion}`;
switch (apiVersion) {
case "v1":
storage.setItem(API_VERSION_STORAGE_KEYS.v1, this.axiosInstance.defaults.baseURL);
Expand Down Expand Up @@ -265,6 +265,8 @@ const DEFAULT_ENDPOINT = `${process.env.PD_API_ENDPOINT || "http://localhost:300
const LOCAL_STORAGE_KEY_V1 = "pd.devtool.endpoint";
const LOCAL_STORAGE_KEY_V2 = "pd.devtool.endpoint.v2";

const sanitizeEndpoint = (url: string) => url.trim().replace(/\/+$/, "");

// Create apiclient instance with endpoint from storage or default
export const getEndpointFromStorage = () => {
let endpoint = "";
Expand All @@ -275,7 +277,7 @@ export const getEndpointFromStorage = () => {
endpoint = DEFAULT_ENDPOINT;
}

return endpoint.replace("/_pd/api/v1", "").replace("/_pd/api/v2", ""); // compatible with old endpoint
return sanitizeEndpoint(endpoint.replace("/_pd/api/v1", "").replace("/_pd/api/v2", "")); // compatible with old endpoint
};

/**
Expand Down
Loading