docs: add migration guide for AccessControlDefaultAdminRules#6472
docs: add migration guide for AccessControlDefaultAdminRules#6472JunaidCD wants to merge 1 commit intoOpenZeppelin:masterfrom
Conversation
Resolves an audit finding suggesting more prominent documentation and migration guides for existing contracts regarding the use of AccessControlDefaultAdminRules to secure DEFAULT_ADMIN_ROLE.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughDocumentation was added to the access control module describing migration from Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolves an audit finding suggesting more prominent documentation and migration guides for existing contracts regarding the use of AccessControlDefaultAdminRules to secure DEFAULT_ADMIN_ROLE.
Fixes #6413
Changes Introduced
Migrating to AccessControlDefaultAdminRulessection todocs/modules/ROOT/pages/access-control.adoc.AccessControlDefaultAdminRulesrequires inheritance and provided an example on how to migrate for new or un-deployed contracts.AccessManagerorTimelockController.PR Checklist
npx changeset add)