Skip to content

Add flash mint note #6458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
james-toussaint wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Add flash mint note #6458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion contracts/token/ERC20/extensions/ERC20FlashMint.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ abstract contract ERC20FlashMint is ERC20, IERC3156FlashLender {
* @return `true` if the flash loan was successful.
*/
// This function can reenter, but it doesn't pose a risk because it always preserves the property that the amount
// minted at the beginning is always recovered and burned at the end, or else the entire function will revert.
// minted at the beginning is always recovered and burned at the end (provided `_mint` and `_burn` are symmetric,
// e.g. the token doesn't take a native fee inside `_burn`, which is reasonable considering the flash loan context),
// or else the entire function will revert.
// slither-disable-next-line reentrancy-no-eth
function flashLoan(
IERC3156FlashBorrower receiver,
Expand Down