Add build flag to enable UBSAN in tests#916
Open
cegonse wants to merge 1 commit intoOpenWaterAnalytics:devfrom
Open
Add build flag to enable UBSAN in tests#916cegonse wants to merge 1 commit intoOpenWaterAnalytics:devfrom
cegonse wants to merge 1 commit intoOpenWaterAnalytics:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new CMake build flag,
SANITIZERS_ENABLED=ON/OFF, to enable the Undefined Behavior Sanitizer (UBSAN) in tests.UBSAN detects undefined behavior in runtime such as signed integer overflow, integer division by zero, function calls through function pointers with wrong signatures, etc (full list).
Undefined behavior can be a cause of hard to detect bugs in C code, with problems compounding when optimizations are enabled. Using UBSAN can help during development, making detecting these issues early.
Only enabled if supported by the toolchain, otherwise ignored.
Tested with Clang 14.0.6, no undefined behaviors errors were detected.
Tested working with G++ 12.2.0.