Skip to content

Add billowing#212

Merged
1-Bart-1 merged 25 commits intomainfrom
updated-billowing
Apr 11, 2026
Merged

Add billowing#212
1-Bart-1 merged 25 commits intomainfrom
updated-billowing

Conversation

@1-Bart-1
Copy link
Copy Markdown
Member

@1-Bart-1 1-Bart-1 commented Apr 5, 2026

  • Adds billowing distribution. Works by rotating chord between two unrefined segments with a sinusoidal pattern. Nonlinear solve to achieve a certain percentage trailing edge difference.
  • Fix merge errors with main
  • Fix test failure
  • Fix JETLS warnings

@1-Bart-1 1-Bart-1 changed the title Updated billowing Add billowing Apr 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 5, 2026

Codecov Report

❌ Patch coverage is 84.21053% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/wing_geometry.jl 84.00% 12 Missing ⚠️
ext/VortexStepMethodControlPlotsExt.jl 86.66% 2 Missing ⚠️
ext/VortexStepMethodMakieExt.jl 90.47% 2 Missing ⚠️
src/body_aerodynamics.jl 0.00% 1 Missing ⚠️
src/settings.jl 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@1-Bart-1 1-Bart-1 requested a review from jellepoland April 6, 2026 08:03
@1-Bart-1 1-Bart-1 requested a review from ufechner7 April 11, 2026 10:19
@ufechner7 ufechner7 requested a review from Copilot April 11, 2026 10:35
@ufechner7
Copy link
Copy Markdown
Member

Can you increase the test coverage of the patch?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new “billowing” spanwise panel distribution to model fabric sag between ribs by rotating section chords with a sinusoidal profile, configurable via billowing_percentage and supported through YAML/settings, tests, and an example dataset.

Changes:

  • Add BILLOWING as a PanelDistribution, plus billowing_percentage plumbing through Wing, YAML construction, and settings parsing.
  • Implement TE billowing deformation during mesh refinement via per-rib-pair chord rotation with a nonlinear solve to match a target TE arc-length percentage.
  • Add billowing tests, example script, documentation entry, and V3 kite sample data; update Makie plotting with shared legends and optional CL/CD plotting; clamp elliptical gamma distribution to avoid domain errors.

Reviewed changes

Copilot reviewed 34 out of 35 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
test/wing_geometry/test_billowing.jl New test coverage for billowing geometry behavior and edge cases.
test/runtests.jl Registers the new billowing test file in the test runner.
test/Project.toml Adjusts test dependencies/compat and adds a dependency entry for the package under test.
src/yaml_geometry.jl Adds billowing_percentage keyword support to YAML-based Wing construction.
src/wing_geometry.jl Adds billowing_percentage to Wing, implements billowing refinement + helpers, and integrates BILLOWING into refine!.
src/VortexStepMethod.jl Exports and documents the new BILLOWING panel distribution enum value.
src/settings.jl Adds billowing_percentage to WingSettings and parses it from settings YAML.
src/obj_geometry.jl Updates manual Wing struct construction to include the new billowing_percentage field.
src/body_aerodynamics.jl Clamps elliptical gamma computation to avoid sqrt domain errors.
Project.toml Formatting-only change (version line alignment).
NEWS.md Documents breaking/added/changed/fixed items related to billowing and other updates.
ext/VortexStepMethodMakieExt.jl Moves legends to shared layout, adds cl_over_cd option, and updates plotting layout.
examples/billowing.jl New example comparing flat vs billowed V3 kite results.
docs/src/examples.md Adds billowing example to the documented examples menu.
data/TUDELFT_V3_KITE/vsm_settings_coarse.yaml New coarse V3 settings YAML including billowing_percentage.
data/TUDELFT_V3_KITE/aero_geometry_coarse_discretisation.yaml New coarse V3 geometry YAML used by the billowing example.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/1.csv Adds CFD/NF combined polar data for airfoil 1.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/2.csv Adds CFD/NF combined polar data for airfoil 2.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/3.csv Adds CFD/NF combined polar data for airfoil 3.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/4.csv Adds CFD/NF combined polar data for airfoil 4.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/5.csv Adds CFD/NF combined polar data for airfoil 5.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/6.csv Adds CFD/NF combined polar data for airfoil 6.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/8.csv Adds CFD/NF combined polar data for airfoil 8.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/10.csv Adds CFD/NF combined polar data for airfoil 10.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/11.csv Adds CFD/NF combined polar data for airfoil 11.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/12.csv Adds CFD/NF combined polar data for airfoil 12.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/13.csv Adds CFD/NF combined polar data for airfoil 13.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/14.csv Adds CFD/NF combined polar data for airfoil 14.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/15.csv Adds CFD/NF combined polar data for airfoil 15.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/16.csv Adds CFD/NF combined polar data for airfoil 16.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/17.csv Adds CFD/NF combined polar data for airfoil 17.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/18.csv Adds CFD/NF combined polar data for airfoil 18.
data/TUDELFT_V3_KITE/polars_CFD_NF_combined/19.csv Adds CFD/NF combined polar data for airfoil 19.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/wing_geometry.jl
Comment thread src/wing_geometry.jl Outdated
Comment thread ext/VortexStepMethodMakieExt.jl
Comment thread ext/VortexStepMethodMakieExt.jl
Comment thread test/Project.toml
Comment thread data/TUDELFT_V3_KITE/vsm_settings_coarse.yaml
Comment thread data/TUDELFT_V3_KITE/vsm_settings_coarse.yaml
Comment thread test/wing_geometry/test_billowing.jl
Comment thread docs/src/examples.md
@1-Bart-1
Copy link
Copy Markdown
Member Author

Patch coverage should be better now

Copy link
Copy Markdown
Member

@ufechner7 ufechner7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increase code coverage.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 36 out of 37 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread data/TUDELFT_V3_KITE/vsm_settings_coarse.yaml Outdated
Comment thread data/TUDELFT_V3_KITE/vsm_settings_coarse.yaml Outdated
Comment thread ext/VortexStepMethodMakieExt.jl
Comment thread ext/VortexStepMethodMakieExt.jl
Comment thread examples/billowing.jl Outdated
Comment thread test/wing_geometry/test_billowing.jl Outdated
Comment thread test/wing_geometry/test_billowing.jl
Comment thread test/wing_geometry/test_billowing.jl Outdated
@1-Bart-1 1-Bart-1 requested a review from ufechner7 April 11, 2026 20:18
@1-Bart-1 1-Bart-1 merged commit 2314f63 into main Apr 11, 2026
9 checks passed
@1-Bart-1 1-Bart-1 deleted the updated-billowing branch April 11, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants