Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Can you increase the test coverage of the patch? |
There was a problem hiding this comment.
Pull request overview
Adds a new “billowing” spanwise panel distribution to model fabric sag between ribs by rotating section chords with a sinusoidal profile, configurable via billowing_percentage and supported through YAML/settings, tests, and an example dataset.
Changes:
- Add
BILLOWINGas aPanelDistribution, plusbillowing_percentageplumbing throughWing, YAML construction, and settings parsing. - Implement TE billowing deformation during mesh refinement via per-rib-pair chord rotation with a nonlinear solve to match a target TE arc-length percentage.
- Add billowing tests, example script, documentation entry, and V3 kite sample data; update Makie plotting with shared legends and optional CL/CD plotting; clamp elliptical gamma distribution to avoid domain errors.
Reviewed changes
Copilot reviewed 34 out of 35 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| test/wing_geometry/test_billowing.jl | New test coverage for billowing geometry behavior and edge cases. |
| test/runtests.jl | Registers the new billowing test file in the test runner. |
| test/Project.toml | Adjusts test dependencies/compat and adds a dependency entry for the package under test. |
| src/yaml_geometry.jl | Adds billowing_percentage keyword support to YAML-based Wing construction. |
| src/wing_geometry.jl | Adds billowing_percentage to Wing, implements billowing refinement + helpers, and integrates BILLOWING into refine!. |
| src/VortexStepMethod.jl | Exports and documents the new BILLOWING panel distribution enum value. |
| src/settings.jl | Adds billowing_percentage to WingSettings and parses it from settings YAML. |
| src/obj_geometry.jl | Updates manual Wing struct construction to include the new billowing_percentage field. |
| src/body_aerodynamics.jl | Clamps elliptical gamma computation to avoid sqrt domain errors. |
| Project.toml | Formatting-only change (version line alignment). |
| NEWS.md | Documents breaking/added/changed/fixed items related to billowing and other updates. |
| ext/VortexStepMethodMakieExt.jl | Moves legends to shared layout, adds cl_over_cd option, and updates plotting layout. |
| examples/billowing.jl | New example comparing flat vs billowed V3 kite results. |
| docs/src/examples.md | Adds billowing example to the documented examples menu. |
| data/TUDELFT_V3_KITE/vsm_settings_coarse.yaml | New coarse V3 settings YAML including billowing_percentage. |
| data/TUDELFT_V3_KITE/aero_geometry_coarse_discretisation.yaml | New coarse V3 geometry YAML used by the billowing example. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/1.csv | Adds CFD/NF combined polar data for airfoil 1. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/2.csv | Adds CFD/NF combined polar data for airfoil 2. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/3.csv | Adds CFD/NF combined polar data for airfoil 3. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/4.csv | Adds CFD/NF combined polar data for airfoil 4. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/5.csv | Adds CFD/NF combined polar data for airfoil 5. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/6.csv | Adds CFD/NF combined polar data for airfoil 6. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/8.csv | Adds CFD/NF combined polar data for airfoil 8. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/10.csv | Adds CFD/NF combined polar data for airfoil 10. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/11.csv | Adds CFD/NF combined polar data for airfoil 11. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/12.csv | Adds CFD/NF combined polar data for airfoil 12. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/13.csv | Adds CFD/NF combined polar data for airfoil 13. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/14.csv | Adds CFD/NF combined polar data for airfoil 14. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/15.csv | Adds CFD/NF combined polar data for airfoil 15. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/16.csv | Adds CFD/NF combined polar data for airfoil 16. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/17.csv | Adds CFD/NF combined polar data for airfoil 17. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/18.csv | Adds CFD/NF combined polar data for airfoil 18. |
| data/TUDELFT_V3_KITE/polars_CFD_NF_combined/19.csv | Adds CFD/NF combined polar data for airfoil 19. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Patch coverage should be better now |
ufechner7
left a comment
There was a problem hiding this comment.
Please increase code coverage.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 36 out of 37 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.