Skip to content

Add support for publishing multiple clipboard format on unix/x11 #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LinqLover wants to merge 9 commits into
base: Cog
Choose a base branch
from
Open

Add support for publishing multiple clipboard format on unix/x11 #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
82da0b8
Add support for publishing multiple clipboard format on unix/x11
LinqLover Jan 20, 2026
435052b
make indentations consistent
LinqLover Jan 21, 2026
8c032ad
properly propagate errors and arrange spaces
LinqLover Jan 21, 2026
21147b3
Apply suggestions from code review
LinqLover Jan 21, 2026
6553ec3
Merge branch 'unix-extended-clipboard' of https://github.com/LinqLove…
LinqLover Jan 21, 2026
d220c29
Handle memory allocation failure in display_clipboardGetTypeNames
LinqLover Jan 21, 2026
c5e2644
fix bugs in x11 clipboard:
LinqLover Jan 23, 2026
422ee97
offer meta targets when owning the clipboard ourselves as well; fix n…
LinqLover Jan 24, 2026
4ad924d
ensure fifo order of clipboard offers
LinqLover Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions platforms/unix/plugins/ClipboardExtendedPlugin/sqUnixExtendedClipboard.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ char **clipboardGetTypeNames();
sqInt clipboardSizeWithType(char *typeName, int ntypeName);
sqInt clipboardReadIntoAt(sqInt count, sqInt byteArrayIndex, sqInt startIndex);
void *firstIndexableField(sqInt oop);
void clipboardWriteWithType(char *data, size_t ndata, char *typeName, size_t ntypeName, int isDnd, int isClaiming);
sqInt clipboardWriteWithType(char *data, size_t ndata, char *typeName, size_t ntypeName, int isDnd, int isClaiming);

int formatCounter = 0;

// TODO: clipboardGetTypeNames() should be cached. And the simplest way to do
// this is to have display_clipboardGetTypeNames do the cacheing and freeing,
Expand All @@ -57,11 +59,10 @@ sqCreateClipboard(void) { return (void *)0xB0A4D; }
void
sqPasteboardClear(void *inPasteboard)
{
// perhaps PrimErrUnsupported is better, but it's inaccurate
// we don't yet have PrimErrUnimplemented

// i.e. this still has to be implemented
interpreterProxy->primitiveFailFor(PrimErrOperationFailed);
int success = clipboardWriteWithType(NULL, 0, "", 0, 0, 0);
formatCounter = 0;
if (!success)
interpreterProxy->primitiveFailFor(PrimErrOperationFailed);
}

/* Return a number of types.
Expand Down Expand Up @@ -112,7 +113,8 @@ sqPasteboardCopyItemFlavorsitemNumber(void *inPasteboard, sqInt formatNumber)
void
sqPasteboardPutItemFlavordatalengthformatTypeformatLength(void *inPasteboard, char *data, sqInt ndata, char *typeName, sqInt ntypeName)
{
clipboardWriteWithType(data, ndata, typeName, ntypeName, 0, 1);
if (!clipboardWriteWithType(data, ndata, typeName, ntypeName, 0, !formatCounter++))
Comment thread
LinqLover marked this conversation as resolved.
interpreterProxy->primitiveFailFor(PrimErrOperationFailed);
}


Expand Down
Loading
Loading