lmstudio: remove unnecessary --set-rpath from patchelf to fix lms segfault#511533
Open
cavebatsofware wants to merge 1 commit intoNixOS:masterfrom
Open
lmstudio: remove unnecessary --set-rpath from patchelf to fix lms segfault#511533cavebatsofware wants to merge 1 commit intoNixOS:masterfrom
cavebatsofware wants to merge 1 commit intoNixOS:masterfrom
Conversation
As described in NixOS#510446 lms segfaults due to an unnecessary "--set-rpath" . Removing that argument resolves the issue with lms.
Contributor
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #510446
As described in #510446, the
lmsCLI tool segfaults due to an unnecessary--set-rpathargument being passed topatchelf.The
lmsbinary is a Node.js/webpack bundle that doesn't require custom library paths. Setting rpath on NixOS can cause ELF header corruption leading to segmentation faults. Only the interpreter needs fixing for AppImage-extracted binaries.Removing the
--set-rpathargument resolves the issue while keeping the necessary--set-interpreterfix.Before (broken):
After (fixed)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.