Draft
Conversation
HDMF 5 added constructor-time validation for DynamicTableRegion that raises IndexError for out-of-bounds indices. Pass validate_data=False in tests that intentionally create invalid DynamicTableRegion objects to test the inspector's own validation checks. Closes #675 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HDMF 5 added constructor-time validation for
DynamicTableRegionthat raisesIndexErrorfor out-of-bounds indices. Passvalidate_data=Falsein tests that intentionally create invalidDynamicTableRegionobjects to test the inspector's own validation checks.Closes #675
Note that pynwb does not yet support HDMF 5 so the dependencies cannot yet be resolved except in local installations where tests pass. This is a WIP until the next pynwb release.