Skip to content

Require account-only BAL reads#11229

Closed
flcl42 wants to merge 5 commits intomasterfrom
fix-read-account-only
Closed

Require account-only BAL reads#11229
flcl42 wants to merge 5 commits intomasterfrom
fix-read-account-only

Conversation

@flcl42
Copy link
Copy Markdown
Contributor

@flcl42 flcl42 commented Apr 18, 2026

Fixes kurtosis devnet-3

Changes

  • Require account-only BAL reads

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

LukaszRozmej
LukaszRozmej previously approved these changes Apr 19, 2026
benaadams
benaadams previously approved these changes Apr 19, 2026
@github-actions github-actions Bot added the evm label Apr 19, 2026
@flcl42 flcl42 force-pushed the fix-read-account-only branch from 91ae218 to 987cfd2 Compare April 19, 2026 22:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 19, 2026

EVM Opcode Benchmark Diff

Aggregated runs: base=3, pr=3
Noisy rerun opcodes: DUP4

Regressions (1)

Opcode Base Median (ns) PR Median (ns) Delta Abs Δ (ns) Base CV PR CV Threshold Uncertainty Effective
DUP4 8.881 11.623 +30.87% 2.742 6.0% 9.5% ±5.0% ±10.4% ±19.1%

@benaadams
Copy link
Copy Markdown
Member

Fails now?

@flcl42 flcl42 dismissed stale reviews from benaadams and LukaszRozmej via 29561c2 April 21, 2026 08:37
@flcl42
Copy link
Copy Markdown
Contributor Author

flcl42 commented Apr 21, 2026

@flcl42 flcl42 closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants