Implement scaffold transceiver core contract and placeholder NTT manager#3
Open
cupicmarko wants to merge 2 commits intostellarfrom
Open
Implement scaffold transceiver core contract and placeholder NTT manager#3cupicmarko wants to merge 2 commits intostellarfrom
cupicmarko wants to merge 2 commits intostellarfrom
Conversation
Oghma
reviewed
Dec 23, 2025
Collaborator
Oghma
left a comment
Oghma
left a comment
There was a problem hiding this comment.
It's a good starting point. I left some notes.
In the next PRs we have to
- remove all the panics
- use bytesreader lib from WormholeInterface
- Add errors
- Add the interfaces
- Polishing the code
| [package] | ||
| name = "stellar-ntt-manager" | ||
| version = "0.1.0" | ||
| edition = "2021" |
Collaborator
There was a problem hiding this comment.
Should we use the workspace version instead?
|
|
||
| fn read_u32_be(msg: &Bytes, offset: u32) -> u32 { | ||
| // TODO: Move to other repo if it makes sense | ||
| let b0 = msg |
Collaborator
There was a problem hiding this comment.
What do you think of this version?
let end = offset.checked_add(4).expect("offset overflow");
if msg.len() > end {
panic!("message too short");
}
let mut buf = [0u8; 4];
msg.slice(offset..end).copy_into_slice(&mut buf);
u32::from_be_bytes(buf)
Collaborator
There was a problem hiding this comment.
Or even
let end = offset.checked_add(4).expect("offset overflow");
u32::from_be_bytes(
msg.slice(offset..end)
.try_into()
.expect("message too short"),
)
| let mut out = Bytes::new(env); | ||
|
|
||
| // Layout is: prefix || source_manager || recipient_manager || manager_payload | ||
| out.append(&Bytes::from_array(env, &NTT_PREFIX.to_be_bytes())); |
Collaborator
There was a problem hiding this comment.
out.extend_from_slice(&NTT_PREFIX.to_be_bytes());
out.extend_from_slice(&source_manager.to_array());
out.extend_from_slice(&recipient_manager.to_array());
So we avoid to create an array
|
|
||
| fn read_32_bytes(msg: &Bytes, offset: u32) -> [u8; 32] { | ||
| // TODO: Move to other repo if it makes sense | ||
| let mut out = [0u8; 32]; |
Collaborator
There was a problem hiding this comment.
Same as read_u32_be
let end = offset.checked_add(4).expect("offset overflow");
msg.slice(offset..end)
.try_into()
.expect("message too short")
| args.push_back(consistency.into_val(&env)); | ||
|
|
||
| let res: Result<u64, WormholeError> = | ||
| env.invoke_contract(&core_addr, &Symbol::new(&env, "post_message"), args); |
Collaborator
There was a problem hiding this comment.
Why not instantiate a WormholeInterfaceClient and call post_message?
| verify_args.push_back(vaa_bytes.into_val(&env)); | ||
|
|
||
| let verified: Result<bool, WormholeError> = | ||
| env.invoke_contract(&core_addr, &Symbol::new(&env, "verify_vaa"), verify_args); |
Collaborator
There was a problem hiding this comment.
Initialize a WormholeCoreClient instead
| const KEY_MANAGER_ID: &str = "mi"; | ||
| const KEY_CONSUMED: &str = "c"; | ||
|
|
||
| fn init_key(env: &Env) -> Symbol { |
Collaborator
There was a problem hiding this comment.
If I remember correctly, there are macros for doing that. I mean, as a const
| })); | ||
| assert!(res.is_err()); | ||
|
|
||
| use alloc::string::String; |
Collaborator
There was a problem hiding this comment.
You already defined at line 385. When we have Result implemented, we can delete it.
| env.storage().instance().set(&key, &true); | ||
| } | ||
|
|
||
| #[cfg(test)] |
| @@ -0,0 +1,857 @@ | |||
| #![no_std] | |||
| extern crate alloc; | |||
Collaborator
There was a problem hiding this comment.
I don't think it's necessary. Or, if necessary, only the tests require it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements not-yet complete Wormhole transceiver for Soroban contracts.