fix(state): unify the errors with the old state#3575
Open
MaksymMalicki wants to merge 3 commits intomainfrom
Open
fix(state): unify the errors with the old state#3575MaksymMalicki wants to merge 3 commits intomainfrom
MaksymMalicki wants to merge 3 commits intomainfrom
Conversation
MaksymMalicki
force-pushed
the
maksym/state-cleanups
branch
from
f8e03fe to
b6723fe
Compare
MaksymMalicki
commented
Apr 22, 2026
| } | ||
|
|
||
| // Gets a contract instance from the database. If it doesn't exist returns a contract not deployed error | ||
| func GetContract(r db.KeyValueReader, addr *felt.Felt) (stateContract, error) { |
Contributor
Author
There was a problem hiding this comment.
because the old state returns the db.KeyNotFound in the contract data reads, we also want to return it in the new state. This wrapper makes no sense anymore
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3575 +/- ##
==========================================
- Coverage 74.02% 73.94% -0.09%
==========================================
Files 381 380 -1
Lines 40673 40624 -49
==========================================
- Hits 30108 30038 -70
- Misses 8780 8801 +21
Partials 1785 1785 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MaksymMalicki
force-pushed
the
maksym/state-cleanups
branch
from
d51ddbc to
d26275a
Compare
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.