Add support for tags and tiering_object_tags#590
Open
brinnjoyce wants to merge 3 commits intoNetApp:integration/mainfrom
Open
Add support for tags and tiering_object_tags#590brinnjoyce wants to merge 3 commits intoNetApp:integration/mainfrom
brinnjoyce wants to merge 3 commits intoNetApp:integration/mainfrom
Conversation
Signed-off-by: Brinn Joyce <brinn.joyce@gmail.com>
brinnjoyce
requested review from
carchi8py,
chuyich,
suhasbshekar and
wenjun666
as code owners
wenjun666
reviewed
Nov 4, 2025
wenjun666
reviewed
Nov 4, 2025
wenjun666
reviewed
Nov 4, 2025
wenjun666
reviewed
Nov 4, 2025
wenjun666
reviewed
Nov 4, 2025
wenjun666
reviewed
Nov 4, 2025
wenjun666
reviewed
Nov 4, 2025
brinnjoyce
force-pushed
the
tag_support
branch
from
bba957f to
56d871d
Compare
wenjun666
reviewed
Nov 6, 2025
wenjun666
reviewed
Nov 6, 2025
wenjun666
reviewed
Nov 6, 2025
wenjun666
reviewed
Nov 6, 2025
brinnjoyce
force-pushed
the
tag_support
branch
from
dde732d to
9cc3c47
Compare
wenjun666
reviewed
Nov 18, 2025
| Aggregates []map[string]interface{} `mapstructure:"aggregates,omitempty"` | ||
| Autosize Autosize `mapstructure:"autosize,omitempty"` | ||
| SnapshotLockingEnabled *bool `mapstructure:"snapshot_locking_enabled,omitempty"` | ||
| Tags []string `mapstructure:"tags,omitempty"` |
Contributor
There was a problem hiding this comment.
mapstructure:"tags,omitempty", this works, but let's change it to '_tags' to match the API reference, unless there is a good reason to use 'tags'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #589
Add support for tags and tiering.object_tags to the netapp-ontap_volume resource and the netapp-ontap_volume and netapp-ontap_volumes Data sources.
Along with filtering support to the data sources.