Example on using an EnvironmentFile in the container files#444
Example on using an EnvironmentFile in the container files#444p3ck wants to merge 2 commits intoNeptuneHub:mainfrom
Conversation
Instead of repeating the same Environment entry in each container file. Unfortunately you need to specify the absolute path which may be different.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Podman Quadlet deployment configuration by centralizing environment variables into a new audiomuse.env file. While this improves configuration management, the review identified several critical issues: the default MEDIASERVER_TYPE and POSTGRES_PASSWORD were changed, which breaks backward compatibility with existing deployments. Furthermore, the GEMINI_MODEL_NAME is set to an invalid model version that is inconsistent with the application's defaults.
| @@ -0,0 +1,20 @@ | |||
| # This file needs to be referenced with absolute paths from .container files | |||
| MEDIASERVER_TYPE=jellyfin | |||
There was a problem hiding this comment.
The default MEDIASERVER_TYPE has been changed from navidrome to jellyfin. This is a breaking change for users who were relying on the previous default configuration in the Quadlet files. If the intention is to maintain backward compatibility with the existing deployment files, this should remain navidrome.
MEDIASERVER_TYPE=navidrome
| JELLYFIN_USER_ID= | ||
| JELLYFIN_TOKEN= | ||
| POSTGRES_USER=audiomuse | ||
| POSTGRES_PASSWORD=audiomuse |
There was a problem hiding this comment.
The POSTGRES_PASSWORD value (audiomuse) does not match the previous hardcoded value (audiomusepassword) used in the container files, nor does it match the default fallback in config.py. This discrepancy will cause database connection failures for existing deployments or if the user expects the default password to work.
POSTGRES_PASSWORD=audiomusepassword
| POSTGRES_PORT=5432 | ||
| REDIS_URL=redis://localhost:6379/0 | ||
| GEMINI_API_KEY= | ||
| GEMINI_MODEL_NAME=google/gemini-3-flash-preview |
There was a problem hiding this comment.
The GEMINI_MODEL_NAME value (google/gemini-3-flash-preview) is inconsistent with the default value in config.py (gemini-2.5-pro). Furthermore, "gemini-3" is not a valid model version for the Gemini API. It is recommended to use a valid model name like gemini-1.5-flash and ensure consistency with the application code.
GEMINI_MODEL_NAME=gemini-1.5-flash
1 participant
Instead of repeating the same Environment entry in each container file. Unfortunately you need to specify the absolute path which may be different.