Open
Conversation
…rent version started to normalize all images so that min(data) become black and max(data) become white, making need for more code, etc. not cool.
- rewrite all local imports to relative paths - reorder imports correctly - add setup.py with CLI entry_points for top-level scripts - rewrite shell scripts to use CLIs - update README
This was referenced Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds proper setuptools packaging under the (free) name
pix2pixhd, using the meta-data available.(If you want, I can make a release on PyPI, too.)
Builds on the following PRs:
Instead of having to run the scripts files via Python, this defines entry points:
(I already updated the README, accordingly.)
I was able to run the test example successfully (on GPU and on CPU).