Remove _StridedLayout from cuda.core public API#1932
Merged
Conversation
_StridedLayout is a private symbol (underscore-prefixed) that was imported from cuda.core._layout into cuda/core/__init__.py, making it unintentionally available as a public name. All internal usage (in _memoryview.pyx) already imports it directly via cimport from the private module, so the re-export in __init__.py is unnecessary.
mdboom
added
bug
mdboom
added
enhancement
This comment has been minimized.
This comment has been minimized.
cpcloud
approved these changes
Apr 17, 2026
|
mdboom
added a commit
to mdboom/cuda-python
that referenced
this pull request
Apr 20, 2026
_StridedLayout is a private symbol (underscore-prefixed) that was imported from cuda.core._layout into cuda/core/__init__.py, making it unintentionally available as a public name. All internal usage (in _memoryview.pyx) already imports it directly via cimport from the private module, so the re-export in __init__.py is unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm doing this as part of auditing the cuda.core API. This exposure of a private class may be intentional -- I don't have enough context.
Solutions include:
Bot summary below:
Problem:
_StridedLayoutis a private symbol (underscore-prefixed) imported fromcuda.core._layoutintocuda/core/__init__.py, making it unintentionally available as a public name in thecuda.corenamespace.Fix: Remove the
_StridedLayoutimport from__init__.py. All internal usage (in_memoryview.pyx) already imports it directly viacimportfrom the private module, so the re-export is unnecessary.