Prepare testing in tile mode for libcu++#8505
Open
miscco wants to merge 2 commits intoNVIDIA:mainfrom
Open
Conversation
miscco
force-pushed
the
basic_tile_support
branch
2 times, most recently
from
2a00de5 to
59e21d4
Compare
davebayer
reviewed
Apr 17, 2026
| # define _CCCL_CUDA_COMPILATION() 0 | ||
| #endif // ^^^ not compiling .cu file ^^^ | ||
|
|
||
| #ifdef __CUDACC_TILE__ |
Contributor
There was a problem hiding this comment.
Suggested change
| #ifdef __CUDACC_TILE__ | |
| #if defined(__CUDACC_TILE__) |
I think we always use defined, I don't even know why :D
Contributor
Author
There was a problem hiding this comment.
I believe there will be a lot of clang-tidy issues because that prefers ifdef when possible
Comment on lines
+31
to
42
| # ifdef __CUDACC_TILE__ | ||
| # define _CCCL_TILE __tile__ | ||
| # else // ^^^ __CUDACC_TILE__ ^^^ / vvv !__CUDACC_TILE__ vvv | ||
| # define _CCCL_TILE | ||
| # endif // !__CUDACC_TILE__ | ||
| #else // ^^^ _CCCL_CUDA_COMPILATION ^^^ / vvv !_CCCL_CUDA_COMPILATION vvv | ||
| # define _CCCL_HOST | ||
| # define _CCCL_DEVICE | ||
| # define _CCCL_HOST_DEVICE | ||
| # define _CCCL_TILE | ||
| #endif // !_CCCL_CUDA_COMPILATION | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| # ifdef __CUDACC_TILE__ | |
| # define _CCCL_TILE __tile__ | |
| # else // ^^^ __CUDACC_TILE__ ^^^ / vvv !__CUDACC_TILE__ vvv | |
| # define _CCCL_TILE | |
| # endif // !__CUDACC_TILE__ | |
| #else // ^^^ _CCCL_CUDA_COMPILATION ^^^ / vvv !_CCCL_CUDA_COMPILATION vvv | |
| # define _CCCL_HOST | |
| # define _CCCL_DEVICE | |
| # define _CCCL_HOST_DEVICE | |
| # define _CCCL_TILE | |
| #endif // !_CCCL_CUDA_COMPILATION | |
| #else // ^^^ _CCCL_CUDA_COMPILATION ^^^ / vvv !_CCCL_CUDA_COMPILATION vvv | |
| # define _CCCL_HOST | |
| # define _CCCL_DEVICE | |
| # define _CCCL_HOST_DEVICE | |
| #endif // !_CCCL_CUDA_COMPILATION | |
| #if _CCCL_TILE_COMPILATION() | |
| # define _CCCL_TILE __tile__ | |
| #else // ^^^ _CCCL_TILE_COMPILATION() ^^^ / vvv !_CCCL_TILE_COMPILATION() vvv | |
| # define _CCCL_TILE | |
| #endif // ^^^ !_CCCL_TILE_COMPILATION() ^^^ |
Comment on lines
+67
to
+72
| if (CMAKE_CUDA_COMPILER_VERSION VERSION_LESS_EQUAL 13.2) | ||
| message( | ||
| FATAL_ERROR | ||
| "tile programs are not supported in NVCC until after 13.2" | ||
| ) | ||
| endif() |
Contributor
There was a problem hiding this comment.
We should check that the CUDA compiler is nvcc
Contributor
There was a problem hiding this comment.
also, I would suggest the opposite condition VERSION_GREATER_EQUAL 13.3
Contributor
Author
There was a problem hiding this comment.
but we do not know the next version of NVCC
Contributor
😬 CI Workflow Results🟥 Finished in 3h 25m: Pass: 97%/478 | Total: 15d 04h | Max: 3h 25m | Hits: 47%/521527See results here. |
miscco
force-pushed
the
basic_tile_support
branch
from
59e21d4 to
7135d16
Compare
Many headers are not suitable for tile programming or rely on features that are not available in tile programs, e.g. our atomic types that require `asm`. Disable those header tests that fail currently
miscco
force-pushed
the
basic_tile_support
branch
from
7135d16 to
cf6e804
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tile programing has been anounced and we want to be ready for the user to use libcu++ features in tile mode
This adds basic functionality to build libcu++ in tile mode once the next CTK is actually released.
Note that there are a number of additional changes needed to make some features work and that some features are not going to be suppported in the future