Skip to content

MCR-3680 fix mrcurl del-param#2913

Draft
golsch wants to merge 2 commits intomainfrom
issues/MCR-3680-fix_mcurl_del_param
Draft

MCR-3680 fix mrcurl del-param#2913
golsch wants to merge 2 commits intomainfrom
issues/MCR-3680-fix_mcurl_del_param

Conversation

@golsch
Copy link
Copy Markdown
Member

@golsch golsch commented Apr 15, 2026

Link to jira.

Pull Request Checklist (Author)

Please go through the following checklist before assigning the PR for review:

Ticket & Documentation

  • The issue in the ticket is clearly described and the solution is documented.
  • Design decisions (if any) are explained.
  • The ticket references the correct source and target branches.
  • The fixed-version is correctly set in the ticket and matches the PR's target branch (main).

Feature & Improvement Specific Checks

  • Instructions on how to test or use the feature are included or linked (e.g. to documentation).
  • For UI changes: before & after screenshots are attached.
  • New features or migrations are documented.
  • Does this change affect existing applications, data, or configurations?
    • Yes: Is a migration required? If yes, describe it.
    • Breaking change is marked in the commit message.

Bugfix-Specific Checks

  • Affected version is listed in the ticket.
  • Minimal code changes were made (no refactoring).
  • This PR truly fixes only the reported bug.
  • No breaking changes are introduced.
  • A relevant test was added (if feasible).

Testing

  • I have tested the changes locally.
  • The feature behaves as described in the ticket.
  • Were existing tests modified?
    • Yes: explain the changes for reviewers.

MCR Conventions & Metadata

  • MCR naming conventions are followed
  • If the public API has changed:
    • Old API is deprecated or a migration is documented.
    • If not, no action needed.
  • Java license headers are added where necessary.
  • Javadoc is written for non-self-explanatory classes/methods (Clean Code).
  • All configuration options are documented in Javadoc and mycore.properties.
  • No default properties are hardcoded — all set via mycore.properties.

Multi-Repo Considerations

  • Is an equivalent PR in MIR required?
    • If yes, is it already created?

@golsch golsch requested a review from rsteph-de April 15, 2026 13:35
@golsch golsch force-pushed the issues/MCR-3680-fix_mcurl_del_param branch 4 times, most recently from 8906fe2 to 542db9a Compare April 15, 2026 13:52
@golsch golsch force-pushed the issues/MCR-3680-fix_mcurl_del_param branch from 542db9a to 89849ca Compare April 15, 2026 14:06
@rsteph-de rsteph-de marked this pull request as draft April 20, 2026 12:02
@rsteph-de
Copy link
Copy Markdown
Member

rsteph-de commented Apr 20, 2026

I created another PR (forked this branch) and replaced the mcr:del-param URL function see #2919
*** only ONE alternative should be merged !!! **

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants