openscenegraph: backport C++17 and MSVC patches to Conan 1 recipe#1
Merged
sebhmg merged 2 commits intobackport/conan1from Mar 23, 2026
Merged
openscenegraph: backport C++17 and MSVC patches to Conan 1 recipe#1sebhmg merged 2 commits intobackport/conan1from
sebhmg merged 2 commits intobackport/conan1from
Conversation
Backport patches 0007-0011 from the Conan 2 recipe (conan-io/conan-center-index commit 0992b51) to the Conan 1 recipe: - 0007: fix MSVC with std c++17 (upstream PR conan-io#1055) - 0008: replace std::mem_fun_ref (upstream commit 8a0114a) - 0009: replace auto_ptr in plugins (upstream PR conan-io#1246) - 0010: replace ptr_fun in obj plugin (upstream PR conan-io#1246) - 0011: remove deprecated register keyword (upstream PR conan-io#1296) Also add patch_description/patch_type/patch_source metadata to all patches (0001-0011) per CCI conandata.yml schema requirements.
Backport patches 0012-0013 from the Conan 2 recipe (conan-io/conan-center-index commit 51b1282) to the Conan 1 recipe: - 0012: fix MSVC _FPOSOFF removal (upstream issue conan-io#1323) - 0013: fix MSVC unnamed typedef struct (upstream commit 3e7bdc0)
sebhmg
force-pushed
the
backport/osg-conan1-patches
branch
from
3e8d1a2 to
ae132df
Compare
Author
|
on this one, I have been well assisted by copilot with Claude Opus ! |
andrewg-mira
approved these changes
Mar 23, 2026
benjaminc-mirageoscience
approved these changes
Mar 23, 2026
sebhmg
pushed a commit
that referenced
this pull request
Mar 23, 2026
* add v5.15.17 * remove unused qtmodules files (#1) * 5.15.18 * Apply suggestions from code review Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com> * Update recipes/qt/5.x.x/conandata.yml Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com> * qt5: remove unreferenced patches * qt5 fix patches --------- Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com> Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
openscenegraph/3.6.5: Backport patches from the Conan 2 recipe to the Conan 1 recipe.Patch files added
From
conan-io/conan-center-index@0992b51e(conan-io#23704 Migrate/openscenegraph):byteambiguous symbol error (std::bytevsrpcndr.hbyte) when building with C++17 on MSVC with recent Windows SDK (10.0.26100.0+). Movesusing namespace stdafter Windows headers inDisplaySettings.cpp.std::mem_fun_ref(removed in C++17).std::auto_ptrin plugins (removed in C++17)./std:c++17msvc flag openscenegraph/OpenSceneGraph#1246std::ptr_funin obj plugin (removed in C++17)./std:c++17msvc flag openscenegraph/OpenSceneGraph#1246registerkeyword (deprecated in C++17).registerkeyword to enable C++17 compatibility with Apple Clang openscenegraph/OpenSceneGraph#1296From
conan-io/conan-center-index@51b1282e(conan-io#28121 openscenegraph: added some patches):_FPOSOFFidentifier not found.Modified files
recipes/openscenegraph/all/conandata.yml— Added entries for patches 0007–0013 withbase_path: source_subfolder(Conan 1 format).Context
Building OpenSceneGraph 3.6.5 with
compiler.cppstd=17on MSVC with Windows SDK 10.0.26100.0+ fails with:These patches were already present in the Conan 2 rewrite of the recipe but were never backported to the Conan 1 recipe.