Move connection logic in accept and connect calls#128
Draft
tvegas1 wants to merge 1 commit intoMellanox:masterfrom
Draft
Move connection logic in accept and connect calls#128tvegas1 wants to merge 1 commit intoMellanox:masterfrom
tvegas1 wants to merge 1 commit intoMellanox:masterfrom
Conversation
Collaborator
Author
|
pls look @brminich |
Collaborator
Author
|
on hold, conflicts with NET_SHARED_COMMS=1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When changing worker vs ep allocation scheme, the connection step can remain stuck indefinitely, as the loop on
ucp_worker_progress()does not allow unrelated request progress anymore.What
Move from blocking to non-blocking for connection establishment.
How
Move connection steps from
isend()/irecv()toconnect()/accept()and use similar state machine management steps from other plugins.