Merged
Conversation
Binds vim-style navigation in the results table: gg / G go to first/last row Ctrl+U / D page up/down 0 / $ first/last column of current row f / F filterable column picker (Enter to jump, Esc to cancel) Closes #170
gg/G and Ctrl+U/Ctrl+D now keep the current column instead of resetting to column 0 (gg) or the last column (G). FastDataTable's built-in action_cursor_table_start/end clobber the column, so dispatch through a helper that sets cursor_coordinate with the original column preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #170.
Adds vim-style navigation to the results table:
gg/G— first / last rowCtrl+U/Ctrl+D— page up / down0/$— first / last column of the current rowf/F— filterable column picker; typing narrows the list,Enterjumps the cursor to that column,Esccancelsggreuses the existing leader-menu pattern (newrgmenu, mirroring howgworks in the query editor). The other motions delegate toFastDataTable's ownaction_cursor_*/action_page_*methods, so scroll-follow, wrapping, and empty-table behavior come for free.Tests in
tests/ui/keybindings/test_results_vim_motions.pydrive the app with Textual's pilot, populate results via_display_query_results, and assertcursor_coordinateafter each key press.