feat: add bash/zsh completion for p11* tools

[mdevolde]

This PR adds bash completion support for several p11* CLI tools.

Features

• Shared logic in completion/p11-common
• Specific completions for: p11cat, p11cp, p11kcv, p11ls, p11more, p11mv, p11od, p11setattr
• Supports PKCS11LIB, PKCS11SLOT, PKCS11PASSWORD as environment fallback
• Documented usage, environment handling, and limitations

Makefile

• Adds completion scripts to EXTRA_DIST
• Installs them to ${datadir}/bash-completion/completions

Limitations

• Does not support inline env variables (e.g. PKCS11LIB=... p11cat)
• Zsh is not yet supported, could be addressed in a later contribution

[Copilot]

Pull Request Overview

This PR adds Bash autocompletion support for various p11* CLI tools by introducing a shared common script and individual completion scripts, and updating the Makefile.am to install them.

• Introduce completion/p11-common with reusable parsing and completion functions.
• Add dedicated completion scripts for p11cat, p11cp, p11kcv, p11ls, p11more, p11mv, p11od, and p11setattr.
• Update Makefile.am to include these scripts in EXTRA_DIST and install them under bash-completion/completions.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
completion/p11-common	Shared functions for parsing -l, -s, -p and completing filters
completion/p11cat	Autocompletion for p11cat
completion/p11cp	Autocompletion for p11cp
completion/p11kcv	Autocompletion for p11kcv
completion/p11ls	Autocompletion for p11ls
completion/p11more	Autocompletion for p11more
completion/p11mv	Autocompletion for p11mv
completion/p11od	Autocompletion for p11od
completion/p11setattr	Autocompletion for p11setattr
Makefile.am	Registers and installs completion scripts

Comments suppressed due to low confidence (2)

completion/p11mv:3

• The comment refers to p11cp but this is the p11mv completion script; update it to p11mv.

# Bash autocompletion for `p11cp`.

completion/p11-common:60

• Consider adding unit or integration tests for __p11_complete_filters to ensure completion logic works correctly across different argument combinations.

__p11_complete_filters() {

[keldonin]

Good stuff.

A few requests:

• It should support ZSH as well
• If possible, infer slots as well - that would require to adapt p11slotinfoto yield a list of slots and token, for completion.

[mdevolde]

I added:

• Completion on all p11 commands
• Slot completion
• Token label completion
• Added a dedicated func in p11slotinfo to handle slot and token completion
• Completion of -i and -w parameters with PKCS11 objects
• Consideration of token labels for PKCS11 object completion
• Added support for PKCS11TOKENLABEL as env fallback
• Basic file completion for relevant parameters (e.g., -l or -o)
• Completion of certain parameters that only accept a predefined list of strings (such as -k on p11keygen, for example).
• Completion of parameters after writing a -.

I did not add completion for:

• -b (p11kcv, p11keygen), -n (p11kcv), -c (p11keycomp), -u (p11mkcert), -e (p11keygen) -> These parameters are just numbers, for which completion is not relevant.
• -p (all), -J (p11keygen, p11rewrap, p11wrap) -> These parameters are PINs or tokens, for which completion is not possible.
• -d (p11mkcert, p11req), -W (p11keygen, p11rewrap, p11wrap) -> Since the user must enter a custom and structured string himself, completion is not relevant.

I wonder if it is relevant to do completion for:

• -m (all) -> Should I just suggest completion with directories, or should I suggest completion with NSS prefixes before directories?
• -a (p11wrap) -> There is a given list of accepted algorithms, but some accept parameters, and these parameters cannot be completed. Should I just provide the algorithms, without the parameters?
• -e (p11mkcert, p11req) -> There are three accepted prefixes (DNS, email, IP), followed by a value decided by the user. Should I provide completion for these prefixes?

For now, it's still just completion on bash, not zsh.

I also fixed an error in the README, where an obsolete environment variable was listed.

[mdevolde]

Since my last update, I have:

• Added directory completion for -m.
• Added completion for -a algorithms (p11wrap), without adding extra space after, to allow for opening parentheses and specifying parameters.
• Added prefix completion for -e (p11mkcert, p11req), without adding an extra space after, to allow specifying a value.

I also added ZSH compatibility for completions.
Currently, bash completions are used by ZSH. To get more advanced ZSH completion features, such as descriptions, you need to write additional dedicated scripts.

[mdevolde]

Noticed and fixed a compatibility bug for ZSH with bashcompinit (local -n).

[Copilot]

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 9 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.