Skip to content

feat: add play, stop, pause APIs#254

Open
hyochan wants to merge 4 commits intoLonelyCpp:masterfrom
hyochan:upstream/rn-iframe
Open

feat: add play, stop, pause APIs#254
hyochan wants to merge 4 commits intoLonelyCpp:masterfrom
hyochan:upstream/rn-iframe

Conversation

@hyochan
Copy link
Copy Markdown

@hyochan hyochan commented May 1, 2022

I am surprised why this awesome pkg have not yet implemented this.

Please add them 🙏

Thanks in advance.

@tunnaduong
Copy link
Copy Markdown

This is so awesome man, keep it up! I have always wanted these features.

Copy link
Copy Markdown

@vinipachecov vinipachecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this in one of my projects and it is working! I basically edited the files with your changes and run a new build.
LGTM! Great job @hyochan.

@hyochan hyochan changed the title feat: Add play, stop, pause APIs feat: add play, stop, pause APIs Jul 19, 2022
@itsfaraaz
Copy link
Copy Markdown

@LonelyCpp can we please get these merged in?

@sreuter
Copy link
Copy Markdown

sreuter commented Aug 1, 2023

@LonelyCpp Can you have a look at this one?

@kuraydev
Copy link
Copy Markdown

kuraydev commented Aug 1, 2023

It seems this library is not maintaining anymore

@hyochan
Copy link
Copy Markdown
Author

hyochan commented May 30, 2024

I personally ended up installing my own package

@dooboo/react-native-youtube-iframe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants