Skip to content

Force Selenium Manager browser download to use exact browser version and update browsers to latest, more reliable login test, disabling Chromium password leak notification, optimizing Chromium flags#495

Merged
DemeSzabolcs merged 51 commits intodevfrom
issue/OSOE-1064-browser-updates
Mar 28, 2025
Merged

Conversation

@Piedone
Copy link
Copy Markdown
Member

@Piedone Piedone commented Mar 25, 2025 •
edited by atlassian Bot
Loading

@github-actions github-actions Bot changed the title Force Selenium Manager browser download to use exact browser version and update browsers to latest, more reliable login test OSOE-1064: Force Selenium Manager browser download to use exact browser version and update browsers to latest, more reliable login test Mar 25, 2025
@Piedone
Copy link
Copy Markdown
Member Author

Piedone commented Mar 25, 2025

This was what made tests consistent across all environments, including Windows vs Linux.

@Piedone Piedone changed the title OSOE-1064: Force Selenium Manager browser download to use exact browser version and update browsers to latest, more reliable login test Force Selenium Manager browser download to use exact browser version and update browsers to latest, more reliable login test, disabling Chromium password leak notification Mar 25, 2025
Piedone added 20 commits March 26, 2025 01:59
@Piedone
Disabling the unsafe password Chrome popup better
ce41be7
@Piedone
Docs
92dfed6
@Piedone
Fixing potential KeyNotFoundException when cleaning up Cloudflare IP …
26ad335 
…access rules for remote tests
@Piedone
Docs
bd47b3e
@Piedone
Adding missing Obsolete for ClickReliablyOnUntilPageLeaveAsync()
b4b7fc6
@Piedone
Temporarily taking full-screen Window screenshots
723fd91
@Piedone
Deliberately failing test
20a7441
@Piedone
Adding more testing-optimizing Chromium switches
c34591b
@Piedone
Adding missing namespace import
20a07e6
@Piedone
Removing unneeded double dashes from browser CLI arguments (Firefox s…
2f8e993 
…hould remain)
@Piedone
Disable Chrome infobars too
de3d9d5
@Piedone
Fixing code analyzer violation
525227f
@Piedone
Adding temporary Ubuntu screen capture
0d1177b
@Piedone
Trying to fix Ubuntu screenshot
7bb4486
@Piedone
Proper password for the DefaultUser
8fef5f8
@Piedone
Removing UbuntuScreenCapture
93cfc92
@Piedone
Reverting BasicTests
9db686e
@Piedone
Reverting DefaultUser e-mail so it doesn't break ChangeUserSensitiveC…
c071306 
…ontentMaintenanceTaskShouldBeExecutedSuccessfully
@Piedone
Removing unneeded NuGet reference
623a536
@Piedone
Fixing docs
0f5e45e
@Piedone Piedone changed the title Force Selenium Manager browser download to use exact browser version and update browsers to latest, more reliable login test, disabling Chromium password leak notification Force Selenium Manager browser download to use exact browser version and update browsers to latest, more reliable login test, disabling Chromium password leak notification, optimizing Chromium flags Mar 27, 2025
Piedone added 22 commits March 27, 2025 21:17
@Piedone
Some reordering
11db6cb
@Piedone
Trying the first half of the new Chrome options
f9fb721
@Piedone
Easier structuring
3b2c4f4
@Piedone
Trying the second quarter of the new Chrome options
e596a46
@Piedone
Trying the third quarter of the new Chrome options
b9a6cfc
@Piedone
Trying the fourth quarter of the new Chrome options
88a61dc
@Piedone
Disabling all new Chrome options
a3c026d
@Piedone
Trying the first quarter of the new Chrome options
67dc625
@Piedone
Trying the second quarter of the new Chrome options
979b8a2
@Piedone
Trying the third quarter of the new Chrome options
7f87f3b
@Piedone
Trying the fourth quarter of the new Chrome options
8d62195
@Piedone
prBodyNotes is actually an array
120845e
@Piedone
disable-features=OptimizationHints and disable-features=MediaRouter
dacfe1f
@Piedone
deterministic-mode and run-all-compositor-stages-before-draw
864dd49
@Piedone
disable-new-content-rendering-timeout and enable-begin-frame-control
a51647b
@Piedone
disable-threaded-animation and disable-threaded-scrolling
dc39618
@Piedone
disable-checker-imaging and disable-image-animation-resync
db71037
@Piedone
deterministic-mode
9763f96
@Piedone
run-all-compositor-stages-before-draw
3dd1a9a
@Piedone
All Chrome options except for run-all-compositor-stages-before-draw
e648200
@Piedone
Cleaning up Chrome parameters
5fd117d
@Piedone
Typo
23f4312
@DemeSzabolcs DemeSzabolcs merged commit df38e86 into dev Mar 28, 2025
3 checks passed
DemeSzabolcs
DemeSzabolcs reviewed Mar 30, 2025
View reviewed changes
Comment thread Lombiq.Tests.UI/Pages/OrchardCoreLoginPage.cs
}

await context.ClickReliablyOnSubmitAsync();
var buttonBy = ByHelper.ButtonText("Log in");
Copy link
Copy Markdown
Member

@DemeSzabolcs DemeSzabolcs Mar 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized this, but this could be "Sing in" in some other places, so it was better when it was generalized. This caused a failing test in another project.

Copy link
Copy Markdown
Member Author

@Piedone Piedone Mar 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use ClickReliablyOnUntilNavigationHasOccurredAsync here so it is reliable, but feel free to change buttonBy Best would be to use the By of ClickReliablyOnSubmitAsync, like from a static readonly field.

Copy link
Copy Markdown
Member

@sarahelsaig sarahelsaig Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized this, but this could be "Sing in" in some other places

omg new authentication method just dropped!

image
mfw I can't hit the tone to get into my account

Copy link
Copy Markdown
Member Author

@Piedone Piedone Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another is login by piano: https://imgur.com/favorite-of-these-comics-SYvyZ

@DemeSzabolcs DemeSzabolcs mentioned this pull request Mar 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarahelsaig sarahelsaig sarahelsaig left review comments

@DemeSzabolcs DemeSzabolcs DemeSzabolcs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piedone @sarahelsaig @DemeSzabolcs