Conversation
There was a problem hiding this comment.
Hi @b3nj5m1n,
Thank you for taking the time to contribute!
Unfortunately, I haven't defined exactly how to contribute to the dataset (I'll fix it soon). However the reddit source looks great!
Regarding the images, they were generated locally using ComfyUI. If you are comfortable and able to generate them, I can share exactly how they were made. :)
I agree that some equipment is missing, like the pull-up bar (this is the most important problem IMO).
Finally, the progression tree would be a very nice addition (I'd be the first to want it) but it would be hell to implement properly. :(
Now, some guidelines to contribute to the dataset:
- No duplicates (and of course no ID duplicates)
- Must follow schema
- There should be at least one image that is described accurately (at least in part) by the instructions
Let me know what you think!
| "force": "push", | ||
| "level": "intermediate", | ||
| "mechanic": "compound", | ||
| "equipment": "other", |
There was a problem hiding this comment.
The exercise above has the bands equipment while this one has other... Why is that?
| "equipment": "other", | |
| "equipment": "bands", |
| "level": "beginner", | ||
| "mechanic": "isolation", | ||
| "equipment": "bands", | ||
| "primaryMuscles": [ |
There was a problem hiding this comment.
This should have at least one entry... Maybe forearms?
| "secondaryMuscles": [ | ||
| ], | ||
| "instructions": [ | ||
| "https://www.youtube.com/watch?v=mSZWSQSSEjE" |
There was a problem hiding this comment.
There should be actual instructions and not link
| "https://www.youtube.com/watch?v=mSZWSQSSEjE" | |
| "" |
IamDg
added
enhancement
Co-authored-by: IamDg <iamdg.dev@proton.me>
Co-authored-by: IamDg <iamdg.dev@proton.me>
Co-authored-by: IamDg <iamdg.dev@proton.me>
2 participants
This adds a bunch of bodyweight exercises, enough to cover most of the main progressions of the reddit recommended routine.
I did my best to research the targeted muscle groups but obviously can't promise anything, I used an LLM for writing most of the instructions to avoid copyright issues and touched them up a bit myself, but they're still far from perfect. I think most people are probably not using this as their only resource for learning new exercises though, so hopefully that's fine.
Because I couldn't find your code for generating the exercise images, I've left those blank for now.
In some cases, I think we should probably expand some of the available options in
app/src/main/java/org/librefit/enums, for example by adding a pull-up bar or rings to the equipment, although existing exercises are also affected by this (Pull-ups currently require no equipment, for example). The other thing would be hip flexors in the muscle groups, that's something I kept encountering while researching and couldn't find an appropriate option for currently.One area for improvement here would be encoding the information for progressions trees, but maybe that's outside the scope of this project.
Thank you very much for all your work on this project!