Skip to content

🧪 Add unit tests for AwidgetProvider resolveColor#22

Open
LeanBitLab wants to merge 2 commits intomasterfrom
improve-resolve-color-tests-17167287940803020217
Open

🧪 Add unit tests for AwidgetProvider resolveColor#22
LeanBitLab wants to merge 2 commits intomasterfrom
improve-resolve-color-tests-17167287940803020217

Conversation

@LeanBitLab
Copy link
Copy Markdown
Owner

🎯 What: The testing gap addressed
The nested resolveColor function in AwidgetProvider was untestable due to its location and hidden dependencies.

📊 Coverage: What scenarios are now tested
14 new tests added covering:

  • Dynamic colors based on SDK (S vs older).
  • Light vs Dark themes.
  • Primary vs Secondary text.
  • Fallback Default, System, and Custom RGB choices.

Result: The improvement in test coverage
The app's color resolution logic is now completely covered by unit tests, making future refactors safer.


PR created automatically by Jules for task 17167287940803020217 started by @LeanBitLab

- Extracted nested `resolveColor` to companion object for testability.
- Added explicit dependencies to `resolveColor` signature.
- Added JUnit, Mockito dependencies and `isReturnDefaultValues = true`.
- Created 14 unit test cases covering logic of `resolveColor`.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- Fixed build.gradle.kts duplicate mockito dependencies.
- Fixed AwidgetProvider.kt merge conflict where master refactored ColorResolver.
- Verified all tests pass after merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant