fix: retry indefinitely on network loss instead of exiting node#69
Open
Jy-Lau wants to merge 2 commits intoLORD-MicroStrain:rosfrom
Open
fix: retry indefinitely on network loss instead of exiting node#69Jy-Lau wants to merge 2 commits intoLORD-MicroStrain:rosfrom
Jy-Lau wants to merge 2 commits intoLORD-MicroStrain:rosfrom
Conversation
Two bugs caused the NTRIP client to become unrecoverable when network was unavailable at startup or dropped mid-session: 1. ntrip_ros_base.py: run() called connect() once and returned 1 on failure, causing sys.exit() and killing the ROS node. Now retries indefinitely using reconnect_attempt_wait_seconds between attempts. 2. ntrip_base.py: reconnect() raised an Exception after reconnect_attempt_max failures, killing the node. The _connected guard also caused reconnect() to silently do nothing if called while disconnected. Now retries indefinitely with no exception and always disconnects cleanly before attempting reconnect. This allows the node to survive transient network outages (e.g. WiFi not available at launch) and reconnect seamlessly when connectivity is restored, without requiring a manual relaunch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: retry indefinitely on network loss instead of exiting node
Two bugs caused the NTRIP client to become unrecoverable when network
was unavailable at startup or dropped mid-session:
ntrip_ros_base.py: run() called connect() once and returned 1 on
failure, causing sys.exit() and killing the ROS node. Now retries
indefinitely using reconnect_attempt_wait_seconds between attempts.
ntrip_base.py: reconnect() raised an Exception after
reconnect_attempt_max failures, killing the node. The _connected
guard also caused reconnect() to silently do nothing if called while
disconnected. Now retries indefinitely with no exception and always
disconnects cleanly before attempting reconnect.
This allows the node to survive transient network outages (e.g. WiFi
not available at launch) and reconnect seamlessly when connectivity
is restored, without requiring a manual relaunch.