Skip to content

fix: resolve all blockers for first official v1.0.0 release#11

Merged
Kvikku merged 3 commits intomainfrom
copilot/create-official-release
Apr 18, 2026
Merged

fix: resolve all blockers for first official v1.0.0 release#11
Kvikku merged 3 commits intomainfrom
copilot/create-official-release

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 18, 2026

Four blockers were preventing a first official release: no public license, hardcoded version string, stale beta dependency, and a bare tag name in the release workflow.

Changes

  • LICENSE — Added MIT license; updated README badge and license section accordingly
  • Versioning — Added <Version>1.0.0</Version> to all three .csproj files; InteractiveMenu.cs now reads the version at runtime from AssemblyInformationalVersionAttribute instead of the hardcoded v2.0.0:
    var appVersion = System.Reflection.Assembly
        .GetExecutingAssembly()
        .GetCustomAttribute<System.Reflection.AssemblyInformationalVersionAttribute>()
        ?.InformationalVersion.Split('+')[0] ?? "1.0.0";
  • System.CommandLine — Bumped 2.0.0-beta4.22272.1 (2022) → 2.0.0-beta5.25306.1; API-compatible with the existing SetHandler usage, no advisory vulnerabilities
  • Release workflow — Added name: Windows Security Manager ${{ github.ref_name }} to the Create GitHub Release step so the release page renders Windows Security Manager v1.0.0 instead of a bare tag

To cut the release after merging, push a v1.0.0 tag:

git tag v1.0.0 && git push origin v1.0.0

- Add MIT LICENSE file
- Update README: license badge (MIT) and license section
- Add Version 1.0.0 to CLI, GUI, and Core csproj files
- Make InteractiveMenu read version dynamically from assembly metadata
- Update System.CommandLine beta4 → beta5 (2.0.0-beta5.25306.1)
- Add human-readable release name to release.yml workflow step

Agent-Logs-Url: https://github.com/Kvikku/Windows-Security-Manager/sessions/7f2219f0-4a1e-4e60-87c1-f4ee1c012230

Co-authored-by: Kvikku <85877485+Kvikku@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prepares the repository for the first official v1.0.0 release by adding a public license, switching runtime version display to an assembly-derived value, updating a stale CLI dependency, and improving release naming in the GitHub Actions workflow.

Changes:

  • Added MIT LICENSE and updated README license badge/section.
  • Added <Version>1.0.0</Version> to the CLI, Core, and GUI projects; updated the CLI intro screen to display the runtime assembly informational version.
  • Updated System.CommandLine to 2.0.0-beta5.25306.1 and set an explicit GitHub Release name in release.yml.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/WindowsSecurityManager/WindowsSecurityManager.csproj Sets project version to 1.0.0 and updates System.CommandLine package version.
src/WindowsSecurityManager/UI/InteractiveMenu.cs Replaces hardcoded version string with a runtime assembly informational version lookup.
src/WindowsSecurityManager.Gui/WindowsSecurityManager.Gui.csproj Sets GUI project version to 1.0.0.
src/WindowsSecurityManager.Core/WindowsSecurityManager.Core.csproj Sets Core library version to 1.0.0.
README.md Updates license badge and license section to MIT.
LICENSE Adds MIT license text.
.github/workflows/release.yml Sets a human-friendly GitHub Release name including the tag.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +95 to +97
var appVersion = System.Reflection.Assembly
.GetExecutingAssembly()
.GetCustomAttribute<System.Reflection.AssemblyInformationalVersionAttribute>()
@Kvikku
Copy link
Copy Markdown
Owner

Kvikku commented Apr 18, 2026

@copilot apply changes based on the comments in this thread

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 18, 2026

@copilot apply changes based on the comments in this thread

Fixed in 100cdac — added using System.Reflection; at the top of InteractiveMenu.cs and simplified the call site to use the short type names (Assembly, AssemblyInformationalVersionAttribute) instead of the fully-qualified System.Reflection.* prefixes.

Copilot AI requested a review from Kvikku April 18, 2026 18:08
@Kvikku
Copy link
Copy Markdown
Owner

Kvikku commented Apr 18, 2026

@copilot can you fix the buld error?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 18, 2026

@copilot can you fix the buld error?

Fixed in 1f67138. System.CommandLine 2.0.0-beta5 removed extension methods like AddCommand, AddOption, AddArgument, SetHandler, and InvokeAsync from Command/RootCommand, breaking the build. Reverted back to 2.0.0-beta4.22272.1 which matches the existing API usage.

@Kvikku Kvikku marked this pull request as ready for review April 18, 2026 18:19
@Kvikku Kvikku merged commit 6ad9995 into main Apr 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants