fix(vscode): restore chat turn spacing broken by virtualizer#9141
Open
marius-kilocode wants to merge 2 commits intomainfrom
Open
fix(vscode): restore chat turn spacing broken by virtualizer#9141marius-kilocode wants to merge 2 commits intomainfrom
marius-kilocode wants to merge 2 commits intomainfrom
Conversation
The prior spacing fix (#9025) relied on flex `gap` on `.message-list-content`, but #8911 introduced virtua's `Virtualizer` which positions items absolutely based on measured box size — so `gap` no longer applies between turns. The missing spacing was most visible when the last assistant part was a sub-agent's expanded task tool (two bordered boxes with 0px between them). Bake the 12px into each turn's own padding so virtua measures it as part of the item height.
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Fix these issues in Kilo Cloud Other Observations (not in diff)No additional issues outside the diff. Files Reviewed (5 files)
Reviewed by gpt-5.4-20260305 · 409,010 tokens |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gapon.message-list-content, but perf(vscode): paginated message loading with virtualized scroll #8911 introduced virtua'sVirtualizerwhich positions items absolutely based on measured box size — sogapno longer applied between turns.padding-bottomso virtua measures it as part of the item height. This uniformly restores spacing for all turn terminators (text, bash, todos, diffs, subagents, errors).MessageList — sub-agent to queued user spacing) that reproduces the failing case.Before:
After:
