Document Google Ambient Credentials, Add Timeout for Azure Access Token Generation, Add Env Variable Support#58
Conversation
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
There was a problem hiding this comment.
Pull request overview
This PR adds documentation for configuring Google GKE ambient credentials and implements a timeout mechanism for Azure access token generation. The timeout prevents the Azure credential generation process from hanging indefinitely, improving reliability when Azure services are slow or unresponsive.
Key Changes:
- Added comprehensive documentation for configuring GKE workload identity with Keyfactor Command
- Implemented a 10-second timeout for Azure access token retrieval operations
- Added references to the new Google ambient credentials documentation in both the main README and documentation source
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/command/client.go | Added 10-second timeout context for Azure access token generation |
| docsource/content.md | Added link to new Google GKE workload identity documentation |
| docs/ambient-providers/google.md | New comprehensive guide for configuring GKE ambient credentials with Keyfactor Command |
| README.md | Added link to new Google GKE workload identity documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Add environmental variables to chart for use with proxies
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Closing this in favor of a new branch, https://github.com/Keyfactor/command-cert-manager-issuer/tree/feat/AB%2375464/ca-bundle-ambient-credential-updates, which will have feature updates, making it more of a 2.5 release. |
Uh oh!
There was an error while loading. Please reload this page.