Add health check property to Issuer / ClusterIssuer specification#55
Merged
spbsoluble merged 21 commits intorelease-2.4from Nov 17, 2025
Merged
Conversation
…suance flow. Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
…onds Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
irby
changed the title
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
…ers, if not specified.
Ability to specify the default issuer timeout across all issuers
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a configurable health check property to Issuer and ClusterIssuer specifications, enabling users to customize the health check interval and disable health checks if needed. The default behavior maintains backward compatibility with a 60-second health check interval.
- Adds
HealthCheckConfigstruct to the API withenabledandintervalfields - Updates controller to read and validate health check configuration with a minimum interval of 30 seconds
- Adds comprehensive test coverage for various health check scenarios
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| api/v1alpha1/issuer_types.go | Adds HealthCheckConfig struct to IssuerSpec |
| internal/controller/issuer_controller.go | Implements getHealthCheckInterval function with validation logic |
| internal/controller/issuer_controller_test.go | Adds test cases for custom intervals, disabled checks, and validation |
| config/crd/bases/*.yaml | Updates CRD schemas with healthcheck property |
| deploy/charts//templates/crds/.yaml | Updates Helm chart CRDs with healthcheck property |
| cmd/main.go | Adds --default-health-check-interval flag with validation |
| README.md, docsource/content.md | Documents the new healthcheck configuration options |
| e2e/* | Updates e2e tests to use Certificate resources instead of CertificateRequest |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
spbsoluble
deleted the
feat/AB#78226/issuer-healthcheck-configuration
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.