Merged
Conversation
PR #387 added Sigstore-backed provenance to executables, completion files, the man page, and checksums, but missed `benchmark-reports.tar.gz` which is uploaded as a release asset by the `competing_benchmark` job. Without an attestation, there is no cryptographic proof that the archive was generated by this workflow rather than uploaded by hand, leaving the benchmark numbers open to accusations of tampering. Grant the `competing_benchmark` job the `id-token: write` and `attestations: write` permissions (along with the existing `contents: write` it already needs to upload release assets) and run `actions/attest-build-provenance@v2` against `tmp.benchmark-reports.tar.gz` right before it is uploaded.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the release deployment workflow to generate a GitHub artifact attestation (build provenance) for the benchmark report archive produced during the tagged-release “Benchmark” job.
Changes:
- Add explicit job-level permissions needed to upload release assets and create attestations (including OIDC token access) for the benchmark job.
- Create an
actions/attest-build-provenance@v2attestation fortmp.benchmark-reports.tar.gzbefore uploading it to the release.
Performance Regression Reportscommit: 7301ac4 --quantity=apparent-size --max-depth=1 --min-ratio=0.01
LogsJSON{
"results": [
{
"command": "pdu",
"mean": 0.06891549648205128,
"stddev": 0.009028323877432756,
"median": 0.0751293692,
"user": 0.05216932358974359,
"system": 0.1701651543589744,
"min": 0.0568485772,
"max": 0.0817515732,
"times": [
0.0748907342,
0.07540512220000001,
0.0758186132,
0.0753950942,
0.0758674882,
0.0753267702,
0.0755759082,
0.0756997832,
0.0757586492,
0.0757973732,
0.07663492820000001,
0.0817515732,
0.0763469782,
0.0684812382,
0.0755988952,
0.0772808462,
0.0687910112,
0.0752819902,
0.0753144592,
0.0753792932,
0.0748894002,
0.0782404362,
0.0751293692,
0.0758096442,
0.0750772182,
0.0580095862,
0.0569972162,
0.0574555932,
0.0569899942,
0.0570174102,
0.0568485772,
0.0570583542,
0.0579965082,
0.057435433200000004,
0.0570199252,
0.0572434802,
0.0573896702,
0.0571655972,
0.0575342002
],
"exit_codes": [
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0
]
},
{
"command": "pdu-0.20.0",
"mean": 0.05784447900392158,
"stddev": 0.0004531354529431577,
"median": 0.0577499312,
"user": 0.05177695254901961,
"system": 0.17263492509803918,
"min": 0.0570260622,
"max": 0.0588257262,
"times": [
0.0576613852,
0.0577730122,
0.058043204200000004,
0.057665988200000004,
0.0586760012,
0.0573259352,
0.0575006102,
0.0573892512,
0.0577420282,
0.0578906682,
0.0575088132,
0.0584119812,
0.0573779562,
0.0570260622,
0.0581868422,
0.0575742112,
0.0582501842,
0.0575075192,
0.057480822200000004,
0.0578055662,
0.0588257262,
0.0576946562,
0.0574942762,
0.0577499312,
0.057687226200000004,
0.057564928200000004,
0.0572982932,
0.0587921882,
0.0575084452,
0.0578861082,
0.0581809382,
0.0577500122,
0.0578304462,
0.058682429200000004,
0.0580044822,
0.0576084602,
0.0579421672,
0.0585857782,
0.0582553452,
0.0574031192,
0.0579411042,
0.0574039082,
0.0585582572,
0.0572301342,
0.0584599582,
0.0574482422,
0.0578335802,
0.0583496542,
0.0576158122,
0.058408396200000004,
0.0572763832
],
"exit_codes": [
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0,
0
]
}
]
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_011Gvuor8Hf1Q12P2xfVV71v