Skip to content

Restore AbstractString key support for JSON.Object#450

Merged
quinnj merged 1 commit intomasterfrom
codex/issue-449-substring-keys
Apr 22, 2026
Merged

Restore AbstractString key support for JSON.Object#450
quinnj merged 1 commit intomasterfrom
codex/issue-449-substring-keys

Conversation

@quinnj
Copy link
Copy Markdown
Member

@quinnj quinnj commented Apr 22, 2026

Fixes #449.

Summary

  • simplify find_node_by_key so Object{String} lookup works with SubString{String} and other AbstractString keys again
  • route Object{String} mutation and deletion through shared String-key helpers so string-like keys work consistently without recursive dispatch
  • add a regression test that mirrors the issue repro with split(...)[2]

Testing

  • julia --project=. test/object.jl
  • julia --project=. -e 'using Pkg; Pkg.test()'

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (f4fbb5a) to head (76bc682).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   90.26%   90.33%   +0.07%     
==========================================
  Files           7        7              
  Lines        1366     1376      +10     
==========================================
+ Hits         1233     1243      +10     
  Misses        133      133              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@quinnj quinnj merged commit d7e93eb into master Apr 22, 2026
19 of 20 checks passed
@quinnj quinnj deleted the codex/issue-449-substring-keys branch April 22, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SubString keys are not supported since 1.0.0

1 participant