Skip to content

Skip Mooncake tests on GNNLux and Sparse graphs#665

Merged
CarloLucibello merged 4 commits intoJuliaGraphs:masterfrom
Parvm1102:fix/gnnlux-mooncake-skip
Apr 21, 2026
Merged

Skip Mooncake tests on GNNLux and Sparse graphs#665
CarloLucibello merged 4 commits intoJuliaGraphs:masterfrom
Parvm1102:fix/gnnlux-mooncake-skip

Conversation

@Parvm1102
Copy link
Copy Markdown
Contributor

Recently, the GNNLux tests were failing in the CI because the newer version LuxTestUtils v2.3.0 was also checking for AutoMooncake() AD. Most of the layers in GNNLux are not compatible with mooncake. I skipped mooncake for those layers.

@Parvm1102
Copy link
Copy Markdown
Contributor Author

The layers incompatible with Mooncake in GNNLux:

  • Basic: GNNChain
  • Conv: GCNConv, ChebConv, GraphConv, AGNNconv, EdgeConv, DConv, GATConv, GATv2Conv, SGConv, GatedGraphConv, GINConv, NNConv, ResGatedGraphConv and SAGEConv.
  • Pool: GlobalAttentionPool
  • temporalconv: All layers failed

@Parvm1102 Parvm1102 marked this pull request as draft April 4, 2026 18:08
@Parvm1102
Copy link
Copy Markdown
Contributor Author

Parvm1102 commented Apr 4, 2026

@CarloLucibello , Now the GNN / julia 1 test is failing even though nothing is changed in the codebase, the error is as same as the one on GNNLux failure.
This is unexpected because the same test was passing on the last pr. I am currently investigating the issue.

@Parvm1102
Copy link
Copy Markdown
Contributor Author

@CarloLucibello , I tried to find the cause of GNN / julia 1 test failing.
This issue is most likely related to Mooncake v0.5.25 which was released 3 days ago. The PRs were passing tests before that.

It fails with:
MethodError: no method matching zero(::Mooncake.FriendlyTangentCache{Mooncake.AsRaw, Nothing})

The failure is not layer specific. It is related to how the friendly-tangent is changed in v0.5.25. might be related to.
should I try reporting to Mooncake.jl? What should be done with the failing tests as of now?

@Parvm1102 Parvm1102 marked this pull request as ready for review April 5, 2026 10:13
@CarloLucibello
Copy link
Copy Markdown
Member

Let's try to fix the Mooncake tests on GNN Flux. If it cannot be done quickly, let's just skip the Mooncake tests for the time being so that we have CI giving green lights again.

Signed-off-by: Parvm1102 <parvmittal31757@gmail.com>
@Parvm1102
Copy link
Copy Markdown
Contributor Author

Parvm1102 commented Apr 18, 2026

I have skipped the Mooncake testing just for sparse arrays in Flux. This way we don't need to block all tests.
The main reason of failure was friendly_tangents crashed on SparseMatrix with non-float type due to zero, should I report this to Mooncake.jl?

@CarloLucibello please review this pr.

@Parvm1102 Parvm1102 changed the title Fix: GNNLux mooncake skip Skip Mooncake tests on GNNLux and Sparse graphs Apr 18, 2026
@CarloLucibello CarloLucibello merged commit 8a427e4 into JuliaGraphs:master Apr 21, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants