Merged
Conversation
Member
Author
|
For some of the Aqua.jl test failures: CompatHelper has also been silently failing as an action? |
Member
Author
|
For the const jdcnv = Dates.datetime2julianwith jdcnv(d) = Dates.datetime2julian(d)so then these are two different functions, and jdcnv(date...) = jdcnv(DateTime(date...))still works as an un-pirated method? |
Member
|
Sounds reasonable to me |
giordano
reviewed
May 17, 2025
Member
|
Doctests are failing nightly. I'm not really sure it's a good idea to test them with all versions, since you have to deal with floating point results which can fluctuate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.