Skip to content

Update tests#99

Merged
abhro merged 13 commits intomasterfrom
update-tests
May 17, 2025
Merged

Update tests#99
abhro merged 13 commits intomasterfrom
update-tests

Conversation

@abhro
Copy link
Copy Markdown
Member

@abhro abhro commented May 16, 2025

No description provided.

@abhro
Copy link
Copy Markdown
Member Author

abhro commented May 16, 2025

For some of the Aqua.jl test failures: CompatHelper has also been silently failing as an action?

@abhro
Copy link
Copy Markdown
Member Author

abhro commented May 16, 2025

For the jdcnv type piracy issue raised by Aqua.jl, Dates.datetime2julia only provides one method (at the time of writing). Would it be a bad idea to replace

const jdcnv = Dates.datetime2julian

with

jdcnv(d) = Dates.datetime2julian(d)

so then these are two different functions, and

jdcnv(date...) = jdcnv(DateTime(date...))

still works as an un-pirated method?

@cgarling
Copy link
Copy Markdown
Member

Sounds reasonable to me

@abhro abhro marked this pull request as ready for review May 17, 2025 00:05
@abhro abhro requested a review from giordano May 17, 2025 00:24
Comment thread .github/workflows/CI.yml Outdated
@abhro abhro merged commit aa0daec into master May 17, 2025
12 of 13 checks passed
@abhro abhro deleted the update-tests branch May 17, 2025 15:40
@giordano
Copy link
Copy Markdown
Member

Doctests are failing nightly. I'm not really sure it's a good idea to test them with all versions, since you have to deal with floating point results which can fluctuate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants