"VRCFury Support" Allowing the MemoryOptimizer to be used as Component.#24
Open
PenguiniVogel wants to merge 16 commits intoJeTeeS:mainfrom
Open
"VRCFury Support" Allowing the MemoryOptimizer to be used as Component.#24PenguiniVogel wants to merge 16 commits intoJeTeeS:mainfrom
PenguiniVogel wants to merge 16 commits intoJeTeeS:mainfrom
Conversation
- constants are now all together in one file - some functions have moved to be available everywhere - component now lists issues it may have such as compability with UnlimitedParameters Fix: - if system was already installed, it was not checked during build - parameters and fx layer are now copied on the uploading clone to avoid breaking assets - comparison checks now use pre-calculated hash codes to be faster and many more things i can't remember / don't wanna list.
Mention-worthy: - MemoryOptimizer-EditorWindow will attempt to connect to a component if present on the selected avatar - MemoryOptimizer-EditorWindow cannot be opened more than once now since component editing is active-instance based. - a bunch of performance fixes in certain areas - MemoryOptimizerComponent no longer loads duplicates of VRCFury-Components
… we have to re-adjust the count to optimize
- added proper validation for the pipeline since we unhook VRCFury. - optimized the lookup speed in the component by using a dictionary to check. - parameters can be saved as orphans in the event they lose their original link, and will automatically be re-linked, can also be cleared in the settings tab. - GeneratedAssets now get written in the Temp/ directory of the Packages instead of the Assets/, as people tend to dislike clutter in their Assets/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was added:
A new Component "MemoryOptimizerComponent"
This component gets placed on the same object where the
VRCAvatarDescriptorexists, and only one can exist at a time on each Avatar.The component resolves the parameters on the Avatar and tries to resolve VRCFury ones as well (using reflection magic).
Currently supported are:
You can configure the component using the same EditorWindow you use when installing the system, but here comes the major difference (and advantage imo) to using the MemoryOptimizer as component:
The component gets resolved during the build process of the Avatar and installs the MemoryOptimizer into the uploading clone in a non-destructive manner, none of the original files get edited.
If more information is required, or there is open questions, feel free to ask here or on Discord.