git-credential-manager add linux support#259989
Open
readefries wants to merge 1 commit intoHomebrew:mainfrom
Open
git-credential-manager add linux support#259989readefries wants to merge 1 commit intoHomebrew:mainfrom
readefries wants to merge 1 commit intoHomebrew:mainfrom
Conversation
Signed-off-by: Hendrik Bruinsma <hbruinsma@xs4some.nl>
SMillerDev
reviewed
Apr 19, 2026
Comment on lines
+39
to
+43
| (staged_path/"git-credential-manager").write <<~EOS | ||
| #!/bin/sh | ||
| dir="$(dirname "$(realpath "$0")")" | ||
| LD_LIBRARY_PATH="#{HOMEBREW_PREFIX}/opt/icu4c@78/lib" exec "$dir/git-credential-manager-bin" "$@" | ||
| EOS |
Member
There was a problem hiding this comment.
This looks like an upstream bug. Why doesn't the binary work out of the box?
Comment on lines
+30
to
+31
| url "https://github.com/git-ecosystem/git-credential-manager/releases/download/v#{version.major_minor_patch}/gcm-linux-#{arch}-#{version.major_minor_patch}.tar.gz", | ||
| verified: "github.com/git-ecosystem/git-credential-manager/" |
Member
There was a problem hiding this comment.
Why not keep this shared and use #{os} and on_system_block?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.zapstanza paths.I added references to Linux binaries for both x64 and arm64. Validated the install on my devcontainer with the Homebrew image, and verified that the installation and working of the binary was successful. I used it to verify my ideas with existing casks and help craft the changes.