Skip to content

Unregistered teammates bug#142

Merged
avsomers25 merged 2 commits intodevfrom
unregistered-teammates-bug
Sep 16, 2025
Merged

Unregistered teammates bug#142
avsomers25 merged 2 commits intodevfrom
unregistered-teammates-bug

Conversation

@Ayoobf
Copy link
Copy Markdown
Collaborator

@Ayoobf Ayoobf commented Sep 16, 2025

Added registration check. If user is in the 'registered', 'confirmation', or 'coming' state, team creation will work. Any other state will fail

@Ayoobf Ayoobf linked an issue Sep 16, 2025 that may be closed by this pull request
@Ayoobf Ayoobf changed the base branch from main to dev September 16, 2025 03:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds validation to prevent unregistered users from creating teams. The change restricts team creation to users with registration status of 'registered', 'confirmation', or 'coming', blocking users in other states like 'unregistered', 'rejected', or 'waitlist'.

  • Added registration status validation for team leaders and members
  • Updated test fixtures to include registration status fields
  • Added comprehensive test coverage for various registration status scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/functions/teams/create/handler.ts Implements registration status validation logic for team creation
tests/teams-create.test.ts Adds test coverage for registration status validation scenarios
.nvmrc Removes Node.js version specification

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/functions/teams/create/handler.ts Outdated
Comment thread tests/teams-create.test.ts
@avsomers25 avsomers25 merged commit 943ed58 into dev Sep 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Teams allow unregistered teammates.

3 participants