Skip to content

FIX: Made text alignment work when max width is disabled #4025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chetansahney wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −1
Open

FIX: Made text alignment work when max width is disabled #4025

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aab3a1
FIX: Made text alignment work when max width is disabled
Chetansahney Apr 12, 2026
bccfe84
Merge branch 'master' into clean-text-alignment-fix
Chetansahney Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion node-graph/nodes/text/src/text_context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,10 @@ impl TextContext {
let mut layout: Layout<()> = builder.build(text);

layout.break_all_lines(typesetting.max_width.map(|mw| mw as f32));
layout.align(typesetting.max_width.map(|max_w| max_w as f32), typesetting.align.into(), AlignmentOptions::default());

//To make text alignment work when the max width is disabled
let alignment_width = typesetting.max_width.map(|max_w| max_w as f32).or(Some(layout.full_width()));
layout.align(alignment_width, typesetting.align.into(), AlignmentOptions::default());
Comment on lines +85 to +87
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment is missing a space after the slashes. Additionally, while layout.full_width() is likely inexpensive, using or_else is a more idiomatic way to provide a fallback value in Rust as it avoids unnecessary evaluation when max_width is present.

Suggested change
//To make text alignment work when the max width is disabled
let alignment_width = typesetting.max_width.map(|max_w| max_w as f32).or(Some(layout.full_width()));
layout.align(alignment_width, typesetting.align.into(), AlignmentOptions::default());
// To make text alignment work when the max width is disabled
let alignment_width = typesetting.max_width.map(|max_w| max_w as f32).or_else(|| Some(layout.full_width()));
layout.align(alignment_width, typesetting.align.into(), AlignmentOptions::default());


Some(layout)
}
Expand Down